Lock editing system assets on GVL systems

[jpople]

Closes HA-620

Description Of Changes

Disables editing of system assets when the system is locked due to being a GVL vendor.

Code Changes

• Refactors system asset columns
• Adds read-only variants of previously editable cells

Steps to Confirm

Run a Fidesplus backend with TCF enabled.

1. Create a system without a GVL vendor
2. In "Assets" tab, should be able to add, edit and delete assets as normal
3. Create a new system using a GVL vendor with assets (e.g. "AA Media")
4. Form should lock and show GVL notice as normal
5. Save, then navigate to "Assets" tab
6. Should not be able to add, delete, or make any changes to assets

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated
  • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
  • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
• Followup issues:
  • Followup issues created (include link)
  • No followup issues
• Database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!
  • No migrations
• Documentation:
  • Documentation complete, PR opened in fidesdocs
  • Documentation issue created in fidesdocs
  • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • No documentation updates required

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2025 7:33pm
fides-privacy-center	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2025 7:33pm

[andres-torres-marroquin]

looks and feels good, I see that this is not backend protected (in main branch you can still change assets), are there any plans to add locks on the backend side?

[thingscouldbeworse]

ezpz 👍

[jpople]

@andres-torres-marroquin We also don't enforce the lock on the backend for the other system fields-- you can still manually edit the name, description or other information via the API if you want, for example. I don't remember if that's specifically intentional but it's not a change to existing behavior, I don't think it should cause problems.