Skip to content

Celery worker tests#6058

Merged
galvana merged 8 commits intomainfrom
celery-worker-tests
Apr 18, 2025
Merged

Celery worker tests#6058
galvana merged 8 commits intomainfrom
celery-worker-tests

Conversation

@galvana
Copy link
Copy Markdown
Contributor

@galvana galvana commented Apr 17, 2025

Closes LJ-689

Description Of Changes

Fixes Celery worker startup issues and adds a new workflow step to verify that the Celery workers start successfully.

Steps to Confirm

  1. Run nox -s check_worker_startup, it should pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 11:33pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2025 11:33pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (9120c97) to head (d1e7428).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6058   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files         419      419           
  Lines       25968    25968           
  Branches     2828     2828           
=======================================
  Hits        22561    22561           
  Misses       2788     2788           
  Partials      619      619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@galvana galvana added this pull request to the merge queue Apr 18, 2025
@galvana galvana removed this pull request from the merge queue due to a manual request Apr 18, 2025
@galvana galvana merged commit 400bb2e into main Apr 18, 2025
40 checks passed
@galvana galvana deleted the celery-worker-tests branch April 18, 2025 00:29
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 18, 2025

fides    Run #12833

Run Properties:  status check passed Passed #12833  •  git commit 400bb2e6b5: Celery worker tests (#6058)
Project fides
Branch Review main
Run status status check passed Passed #12833
Run duration 00m 51s
Commit git commit 400bb2e6b5: Celery worker tests (#6058)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

tvandort pushed a commit that referenced this pull request Apr 21, 2025
This was referenced Apr 21, 2025
@tvandort tvandort mentioned this pull request May 9, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants