Remove beta flag for detection & discovery features#6059
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jpople
commented
Apr 17, 2025
| <Button | ||
| onClick={() => setGenerateMethod("database")} | ||
| ghost={generateMethod === "database"} | ||
| disabled={features.flags.dataDiscoveryAndDetection} |
Contributor
Author
There was a problem hiding this comment.
Confirmed with product that we want to leave this in.
…ca/fides into jpople/ha-629/dnd-beta-flag
jpople
commented
Apr 17, 2025
| cy.getByTestId("integration-page-btn").click(); | ||
| cy.url().should("contain", INTEGRATION_MANAGEMENT_ROUTE); | ||
| }); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This actually should never have been possible without Plus, whoops.
andres-torres-marroquin
approved these changes
Apr 21, 2025
Contributor
|
needs a changelog entry |
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 52s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes HA-629
Description Of Changes
Removes D&D beta flag.
Steps to Confirm
With Fidesplus backend:
With OSS Fides backend:
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works