Skip to content

HA-631 - Add support for ip_type for GCP SQL connection#6065

Merged
vcruces merged 5 commits intomainfrom
HA-631
Apr 24, 2025
Merged

HA-631 - Add support for ip_type for GCP SQL connection#6065
vcruces merged 5 commits intomainfrom
HA-631

Conversation

@vcruces
Copy link
Copy Markdown
Contributor

@vcruces vcruces commented Apr 18, 2025

Closes HA-631

Description Of Changes

  • Add the ability to specify the “IP Type” as an optional connection argument using Google Cloud SQL (mysql and postgres). This applies to connection tests in:

    • Integrations -> Connection
  • In case of connection error, display error information in admin-ui.

Code Changes

  • Added GCP SQL IP Type Support
    • New ip_type field with options: "public", "private", "psc"
    • Applied to both MySQL and PostgreSQL connectors
    • Default value is "public" if not specified
  • UI Error Handling Improvements
    • Enhanced error messages in connection test responses
    • Added failure reason display in the UI

Steps to Confirm

  1. Have an integration with Google Cloud SQL MySQL (credentials in 1password)
  2. Set the IP type to "public" and see that the connection test works.
  3. Set the IP type to empty and see that the connection test works.
  4. Set the IP type to "private" and see that the connection test fails and the admin-ui displays an error message with the error coming from Google.
  5. Set the IP type to "psc" and see that the connection test fails and the admin-UI displays an error message with the error coming from Google.
  6. Repeat tests with Postgres instead of MySQL.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 5:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2025 5:09pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (6e9bee4) to head (a009e9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6065      +/-   ##
==========================================
+ Coverage   86.85%   86.92%   +0.07%     
==========================================
  Files         419      420       +1     
  Lines       26000    26027      +27     
  Branches     2829     2833       +4     
==========================================
+ Hits        22581    22625      +44     
+ Misses       2806     2787      -19     
- Partials      613      615       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

if (failure_reason) {
description += ` ${failure_reason}`;
}
return <Text data-testid="toast-error-msg">{description}</Text>;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah lovely!

@vcruces vcruces merged commit 5a6ec56 into main Apr 24, 2025
22 checks passed
@vcruces vcruces deleted the HA-631 branch April 24, 2025 17:18
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 24, 2025

fides    Run #12873

Run Properties:  status check passed Passed #12873  •  git commit 5a6ec5645f: HA-631 - Add support for ip_type for GCP SQL connection (#6065)
Project fides
Branch Review main
Run status status check passed Passed #12873
Run duration 00m 51s
Commit git commit 5a6ec5645f: HA-631 - Add support for ip_type for GCP SQL connection (#6065)
Committer Victoria Cruces
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@tvandort tvandort mentioned this pull request Apr 29, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants