Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6065 +/- ##
==========================================
+ Coverage 86.85% 86.92% +0.07%
==========================================
Files 419 420 +1
Lines 26000 26027 +27
Branches 2829 2833 +4
==========================================
+ Hits 22581 22625 +44
+ Misses 2806 2787 -19
- Partials 613 615 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if (failure_reason) { | ||
| description += ` ${failure_reason}`; | ||
| } | ||
| return <Text data-testid="toast-error-msg">{description}</Text>; |
Contributor
There was a problem hiding this comment.
ah lovely!
andres-torres-marroquin
approved these changes
Apr 22, 2025
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | Victoria Cruces |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
vcruces
added a commit
that referenced
this pull request
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes HA-631
Description Of Changes
Add the ability to specify the “IP Type” as an optional connection argument using Google Cloud SQL (mysql and postgres). This applies to connection tests in:
In case of connection error, display error information in admin-ui.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works