Skip to content

Add ability to "restore" muted assets in action center#6080

Merged
jpople merged 4 commits intomainfrom
jpople/ha-567/restore-muted-resources
Apr 23, 2025
Merged

Add ability to "restore" muted assets in action center#6080
jpople merged 4 commits intomainfrom
jpople/ha-567/restore-muted-resources

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Apr 23, 2025

Closes HA-567

Description Of Changes

Adds functionality for "restoring" (un-muting) ignored assets in action center UI.

Steps to Confirm

  1. Populate some web monitor results
  2. Go to action center, click into a system and select and ignore some assets
  3. View "ignored" tab
  4. Should be able to click "restore" inline on an asset
  5. That asset should re-appear in "Attention required"
  6. Should be able to select multiple assets in "Ignored" and select "Restore" from the actions menu
  7. Similarly, selected assets should re-appear in "Attention required"

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 5:51pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 5:51pm

Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the feature and both the restore and bulk restore is working correctly. Code changes look good and they're covered by new tests. Approved 💯

@jpople jpople merged commit b47ae1a into main Apr 23, 2025
17 checks passed
@jpople jpople deleted the jpople/ha-567/restore-muted-resources branch April 23, 2025 17:56
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 23, 2025

fides    Run #12862

Run Properties:  status check passed Passed #12862  •  git commit b47ae1a4f7: Add ability to "restore" muted assets in action center (#6080)
Project fides
Branch Review main
Run status status check passed Passed #12862
Run duration 00m 51s
Commit git commit b47ae1a4f7: Add ability to "restore" muted assets in action center (#6080)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants