Skip to content

LJ-700: Fix Special-purpose only vendors not correctly encoded in TC string#6086

Merged
eastandwestwind merged 6 commits intomainfrom
LJ-700
Apr 24, 2025
Merged

LJ-700: Fix Special-purpose only vendors not correctly encoded in TC string#6086
eastandwestwind merged 6 commits intomainfrom
LJ-700

Conversation

@eastandwestwind
Copy link
Copy Markdown
Contributor

@eastandwestwind eastandwestwind commented Apr 24, 2025

Closes https://ethyca.atlassian.net/browse/LJ-700

Description Of Changes

Fix Special-purpose only vendors not correctly encoded in TC string

Code Changes

  • Update tcf encoding logic to consider special-purpose only vendors
  • Adds specific test for this scenario

Steps to Confirm

  1. Login to the Fides Admin UI
  2. Navigate to the Vendors configuration
  3. Enable a special-purpose only vendor (e.g. SeenThis) in the vendor list
  4. Save the configuration
  5. Ensure you have a system with data use added in Admin-UI
  6. Enable the TCF experience
  7. Visit http://localhost:3001/fides-js-demo.html?geolocation=fr-idf&fides_locale=en
  8. Confirm that SeenThis vendor is listed under Purposes -> Legitimate Interest -> Special purposes section
Screenshot 2025-04-24 at 2 41 09 PM
  1. Make a consent choice (or just x out of the banner), the action doesn't matter
  2. Inspect the generated TC string, either through the console (__tcfapi("getTCData", 2, console.log)), using the IAB chrome extension to inspect, or otherwise, to see that SeenThis is enabled (vendor 415)
Screenshot 2025-04-24 at 2 43 30 PM Screenshot 2025-04-24 at 2 42 43 PM

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2025 4:35pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2025 4:35pm

Comment thread clients/fides-js/src/lib/tcf.ts Outdated
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@eastandwestwind eastandwestwind merged commit 3d3262d into main Apr 24, 2025
17 checks passed
@eastandwestwind eastandwestwind deleted the LJ-700 branch April 24, 2025 16:50
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 24, 2025

fides    Run #12868

Run Properties:  status check passed Passed #12868  •  git commit 3d3262d53a: LJ-700: Fix Special-purpose only vendors not correctly encoded in TC string (#60...
Project fides
Branch Review main
Run status status check passed Passed #12868
Run duration 00m 54s
Commit git commit 3d3262d53a: LJ-700: Fix Special-purpose only vendors not correctly encoded in TC string (#60...
Committer Catherine Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@tvandort tvandort mentioned this pull request Apr 29, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants