Lj 462 Reduce Logging for Disabled Cache on SQLAlchemy#6089
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c0d12fb to
c331176
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (93.75%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6089 +/- ##
=======================================
Coverage 86.92% 86.93%
=======================================
Files 420 421 +1
Lines 26027 26043 +16
Branches 2833 2836 +3
=======================================
+ Hits 22625 22640 +15
Misses 2787 2787
- Partials 615 616 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "cached since", | ||
| "caching disabled", | ||
| "does not support caching", |
There was a problem hiding this comment.
How certain are we that these are the only caching related substrings we need to catch? Are there any other substrings related to PII we might want to guard against (that may or may not be happening now?)
There was a problem hiding this comment.
The one we detected during this Issue was related to caching strategies for third party dialects. Docs over here: https://docs.sqlalchemy.org/en/14/core/connections.html#engine-thirdparty-caching point to the following structure for this error
For all third party dialects that don’t support this attribute, the logging for such a dialect will indicate
dialect does not support caching.
cached since and caching disabled are failsafe nets for similar error that might contain PII, but haven't showed on the logs yet
JadeCara
left a comment
There was a problem hiding this comment.
The tests work for all test cases. I had one question about if we are filtering strongly enough, but this will definitely solve the immediate problem. Approving.
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 54s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Closes LJ#462
Description Of Changes
We were having trouble with unwanted SQLAlchemy log message related to caching issues with third-party dialects like Redshift.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works