Skip to content

conditionally add TCF to the Experience type options#6091

Merged
gilluminate merged 2 commits intomainfrom
gill/LJ-723/when-tcf-is-not-enabled-the
Apr 25, 2025
Merged

conditionally add TCF to the Experience type options#6091
gilluminate merged 2 commits intomainfrom
gill/LJ-723/when-tcf-is-not-enabled-the

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate commented Apr 25, 2025

Closes LJ-723

Description Of Changes

Added conditional logic to display TCF overlay option in the Privacy Experience component type dropdown. The option now appears as the second item in the list only when TCF is enabled in the plusHealth configuration.

Code Changes

  • Created separate constants for base component options and the TCF overlay option
  • Added a dependency on the plusHealth selector to access TCF enabled state
  • Implemented a useMemo to conditionally insert the TCF overlay option when applicable
  • Fixed array ordering to ensure TCF overlay appears as the second item

Steps to Confirm

  1. Verify TCF overlay option appears in the component dropdown when fidesplus FIDES__CONSENT__TCF_ENABLED=true env variable is set
  2. Verify TCF overlay option is not visible when fidesplus FIDES__CONSENT__TCF_ENABLED=false env variable is set or when it's removed entirely
  3. Confirm the TCF overlay option appears as the second item in the dropdown list

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 8:25pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 8:25pm

Copy link
Copy Markdown
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UAT ✅

@gilluminate gilluminate merged commit 60f4b7d into main Apr 25, 2025
17 checks passed
@gilluminate gilluminate deleted the gill/LJ-723/when-tcf-is-not-enabled-the branch April 25, 2025 20:53
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 25, 2025

fides    Run #12878

Run Properties:  status check passed Passed #12878  •  git commit 60f4b7d538: conditionally add TCF to the Experience type options (#6091)
Project fides
Branch Review main
Run status status check passed Passed #12878
Run duration 00m 51s
Commit git commit 60f4b7d538: conditionally add TCF to the Experience type options (#6091)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@tvandort tvandort mentioned this pull request Apr 29, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants