Skip to content

handle errors in redux queries#6094

Merged
tvandort merged 5 commits intomainfrom
handle-errors-in-redux-queries
Apr 28, 2025
Merged

handle errors in redux queries#6094
tvandort merged 5 commits intomainfrom
handle-errors-in-redux-queries

Conversation

@tvandort
Copy link
Copy Markdown
Contributor

@tvandort tvandort commented Apr 28, 2025

image

Description Of Changes

Adds a middleware that turns redux query failures into toasts. Should we consider pushing to an error page?

Code Changes

  • Redux error middleware.

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 4:47pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 4:47pm

@tvandort tvandort force-pushed the handle-errors-in-redux-queries branch from f71cd66 to a8ce5eb Compare April 28, 2025 16:26
Copy link
Copy Markdown
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good-- I would personally favor this approach to an error page, I think it gives more context for what's happening when something goes wrong. Open to other opinions though.

@tvandort
Copy link
Copy Markdown
Contributor Author

Looks good-- I would personally favor this approach to an error page, I think it gives more context for what's happening when something goes wrong. Open to other opinions though.

I considered that, I would also prefer a page.

My question is, is it safe for me to do that here?

@tvandort tvandort merged commit e70d952 into main Apr 28, 2025
17 checks passed
@tvandort tvandort deleted the handle-errors-in-redux-queries branch April 28, 2025 22:30
@cypress
Copy link
Copy Markdown

cypress Bot commented Apr 28, 2025

fides    Run #12882

Run Properties:  status check passed Passed #12882  •  git commit e70d952886: handle errors in redux queries (#6094)
Project fides
Branch Review main
Run status status check passed Passed #12882
Run duration 00m 55s
Commit git commit e70d952886: handle errors in redux queries (#6094)
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants