fix border width to respect variable#6097
Merged
gilluminate merged 2 commits intomainfrom Apr 29, 2025
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
eastandwestwind
approved these changes
Apr 29, 2025
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 54s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes LJ-725
Description Of Changes
When the
--fides-overlay-container-border-widthcss variable is set, it doesn't apply to the banner as expected, only the modal.It does however get applied to the mobile version of the banner, which is where the bug stems from. When the responsive version of the banner was updated, this width was hard coded instead of using the variable.
Fixing this should be low risk in the ecosystem of custom css because if anyone is trying to use that variable to adjust the width, they are likely not being successful and using something hard coded and that will STILL APPLY when this variable gets added to the responsive styling, but it has been marked as high-riskThis issue suggests changes that have a high-probability of breaking existing code
in the change log just in case.
Code Changes
Steps to Confirm
/fides-js-demo.html?geolocation=ca-qu<head>offides-js-demo.html/fides-js-demo.html?geolocation=ca-quPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works