Skip to content

Admin UI Publisher Restriction UX Enhancements#6101

Merged
gilluminate merged 4 commits intomainfrom
gill/publisher-restriction-ux-enhancements
May 1, 2025
Merged

Admin UI Publisher Restriction UX Enhancements#6101
gilluminate merged 4 commits intomainfrom
gill/publisher-restriction-ux-enhancements

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate commented Apr 30, 2025

Description Of Changes

Improves vendor restriction handling in TCF consent settings and fixes UI components. Updates the vendor restriction form to better handle input validation and adds a reusable text header component with info tooltips.

Code Changes

  • Added new TextWithInfoIconHeader component for consistent header styling with tooltips
  • Updated vendor restriction form to:
    • Fix validation logic for "Restrict All Vendors" option
    • Add token separators for vendor ID input (to handle commas and spaces correctly)
    • Remove unnecessary key event handling

Steps to Confirm

  1. Make sure Publisher restrictions feature flag is enabled in /settings/about
  2. Go to Consent settings /settings/consent and make sure "Override vendor purposes" is enabled
  3. Create a new Configuration
  4. Edit a purpose and add a restriction
  5. Select a Restriction type and either vendor restriction that is NOT Restrict all vendors
  6. Paste the following in to the Vendor IDs field: 100,200,300 and press the return key
  7. The field should convert that to individual tags
  8. Now try typing in "100 200 300" with spaces and press the return key.
  9. Pasting and typing should work for both commas and spaces. Play around with that.
  10. Confirm info tooltip appears correctly in Vendors table header

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 3:26pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 1, 2025 3:26pm

values.vendor_restriction ===
TCFVendorRestriction.RESTRICT_ALL_VENDORS
}
tokenSeparators={[",", " "]}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ant!

@gilluminate gilluminate force-pushed the gill/publisher-restriction-ux-enhancements branch from c08aa43 to d9c94ad Compare May 1, 2025 15:25
@gilluminate gilluminate merged commit 9767889 into main May 1, 2025
17 checks passed
@gilluminate gilluminate deleted the gill/publisher-restriction-ux-enhancements branch May 1, 2025 17:06
@cypress
Copy link
Copy Markdown

cypress Bot commented May 1, 2025

fides    Run #12890

Run Properties:  status check passed Passed #12890  •  git commit 9767889ef6: Admin UI Publisher Restriction UX Enhancements (#6101)
Project fides
Branch Review main
Run status status check passed Passed #12890
Run duration 00m 56s
Commit git commit 9767889ef6: Admin UI Publisher Restriction UX Enhancements (#6101)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants