Skip to content

Exclude error logger in test.#6106

Merged
tvandort merged 5 commits intomainfrom
exclude-error-logger-in-test
May 1, 2025
Merged

Exclude error logger in test.#6106
tvandort merged 5 commits intomainfrom
exclude-error-logger-in-test

Conversation

@tvandort
Copy link
Copy Markdown
Contributor

@tvandort tvandort commented May 1, 2025

Closes []

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 5:25pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2025 5:25pm

@tvandort tvandort force-pushed the exclude-error-logger-in-test branch from 3bddca6 to d32914e Compare May 1, 2025 17:20
@tvandort tvandort merged commit 75a8788 into main May 1, 2025
17 checks passed
@tvandort tvandort deleted the exclude-error-logger-in-test branch May 1, 2025 17:35
@cypress
Copy link
Copy Markdown

cypress Bot commented May 1, 2025

fides    Run #12891

Run Properties:  status check passed Passed #12891  •  git commit 75a8788caf: Exclude error logger in test. (#6106)
Project fides
Branch Review main
Run status status check passed Passed #12891
Run duration 00m 54s
Commit git commit 75a8788caf: Exclude error logger in test. (#6106)
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants