Skip to content

Update Add Vendor tooltip to match navigation option#6111

Merged
nrxsmith merged 1 commit intomainfrom
nrs-LJ-742-tooltip
May 6, 2025
Merged

Update Add Vendor tooltip to match navigation option#6111
nrxsmith merged 1 commit intomainfrom
nrs-LJ-742-tooltip

Conversation

@nrxsmith
Copy link
Copy Markdown
Contributor

@nrxsmith nrxsmith commented May 5, 2025

Closes LJ-742

Description Of Changes

This updates a tooltip to refer to a nav menu item by name so it's more clear where the user should go to see the vendor information.

Code Changes

  • Just a tweak to the the tooltip text in one spot

Steps to Confirm

  1. Go to Vendors / Add Vendor
  2. Add any vendor
  3. Go back to Vendors / Add Vendor
  4. Hover over the added vendor to see the new tooltip.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 4:26pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2025 4:26pm

Copy link
Copy Markdown
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! does this need a changelog entry ?

@nrxsmith nrxsmith force-pushed the nrs-LJ-742-tooltip branch from e9253fc to 73d6348 Compare May 6, 2025 16:21
@nrxsmith nrxsmith merged commit 42c14dc into main May 6, 2025
17 checks passed
@nrxsmith nrxsmith deleted the nrs-LJ-742-tooltip branch May 6, 2025 17:06
@cypress
Copy link
Copy Markdown

cypress Bot commented May 6, 2025

fides    Run #12896

Run Properties:  status check passed Passed #12896  •  git commit 42c14dcfb0: Update Add Vendor tooltip to match navigation option (#6111)
Project fides
Branch Review main
Run status status check passed Passed #12896
Run duration 00m 54s
Commit git commit 42c14dcfb0: Update Add Vendor tooltip to match navigation option (#6111)
Committer Nate Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants