Add "view" detail links to action center success toasts#6113
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jpople
commented
May 5, 2025
| Your system has been added to your data map. You can{" "} | ||
| <ToastLink onClick={onViewDatamap}>view it now</ToastLink> and come back | ||
| to finish this setup when you’re ready. Or you can progress to{" "} | ||
| <ToastLink onClick={onViewDatamap}>view it now</ToastLink> or{" "} |
Contributor
Author
There was a problem hiding this comment.
Updated the styling on this to keep it consistent with the new toast links and because it had been bothering me, just tightening up this phrasing too.
andres-torres-marroquin
approved these changes
May 6, 2025
Contributor
andres-torres-marroquin
left a comment
andres-torres-marroquin
left a comment
There was a problem hiding this comment.
Works as expected.
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 57s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
5
|
| View all changes introduced in this branch ↗︎ | |
jjdaurora
pushed a commit
that referenced
this pull request
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes HA-405
Description Of Changes
Adds "View" links to success toasts on action center operations.
Toasts link to the system an asset has been promoted to on promotion ("Add") and to the "Ignored" tab on the appropriate table on ignore.
Steps to Confirm
Run a Fidesplus backend on branch
HA-636; otherwise system keys won't be present to be linked toPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works