Skip to content

Fix action center table issues#6116

Merged
jpople merged 10 commits intomainfrom
jpople/ha-663/action-center-table-fixes
May 7, 2025
Merged

Fix action center table issues#6116
jpople merged 10 commits intomainfrom
jpople/ha-663/action-center-table-fixes

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented May 6, 2025

Closes HA-663

Description Of Changes

Fixes a few UX issues with action center asset tables.

  • Row selection now persists across pages:
Screen.Recording.2025-05-06.at.11.11.07.mov
  • Cell padding is now correct when the checkbox column doesn't render

Before:
Screenshot 2025-05-06 at 11 13 40

After:
Screenshot 2025-05-06 at 11 13 52

  • Last selected system is now properly cleared when bulk assigning a system

Before:

Screen.Recording.2025-05-06.at.11.15.43.mov

After:

Screen.Recording.2025-05-06.at.11.17.30.mov

Steps to Confirm

Populate some web monitor results.

Row selection:

  1. View action center asset table with >25 assets
  2. Select some assets, then page forward and select more assets
  3. Selection state should be preserved across pages
  4. Should be able to take a bulk action (e.g. "Add") from the actions menu and see all selected assets from all pages added

Cell padding:

  1. In system aggregate table and asset table, view "Recent activity" tab (Add some assets to populate this if it's empty)
  2. Asset name cell should be padded appropriately

Assign system modal:

  1. In the asset table, select some assets and use "Assign system" in the Actions menu to assign a system to them
  2. Choose a system and press "Save"
  3. Do the same thing again; on opening the modal, the system select should show the placeholder and not be pre-populated with a value

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 3:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 7, 2025 3:09pm

const rows = cell
.getContext()
.table.getRowModel()
.rows.filter((r) => !r.id.includes(":"));
Copy link
Copy Markdown
Contributor Author

@jpople jpople May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the asset tables to break because the URNs all have ":" in them-- not sure why it was in here originally, it came from the original PR where the datamap report table was added. Cypress tests around the datamap don't seem to be having any issues so I think it can be safely removed?

Copy link
Copy Markdown
Contributor

@andres-torres-marroquin andres-torres-marroquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice UX improvements!

@jpople jpople merged commit 712e189 into main May 7, 2025
17 checks passed
@jpople jpople deleted the jpople/ha-663/action-center-table-fixes branch May 7, 2025 15:30
@cypress
Copy link
Copy Markdown

cypress Bot commented May 7, 2025

fides    Run #12901

Run Properties:  status check passed Passed #12901  •  git commit 712e1893a2: Fix action center table issues (#6116)
Project fides
Branch Review main
Run status status check passed Passed #12901
Run duration 00m 50s
Commit git commit 712e1893a2: Fix action center table issues (#6116)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants