Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jpople
commented
May 6, 2025
| const rows = cell | ||
| .getContext() | ||
| .table.getRowModel() | ||
| .rows.filter((r) => !r.id.includes(":")); |
Contributor
Author
There was a problem hiding this comment.
This was causing the asset tables to break because the URNs all have ":" in them-- not sure why it was in here originally, it came from the original PR where the datamap report table was added. Cypress tests around the datamap don't seem to be having any issues so I think it can be safely removed?
andres-torres-marroquin
approved these changes
May 6, 2025
Contributor
andres-torres-marroquin
left a comment
There was a problem hiding this comment.
Nice UX improvements!
…hub.com/ethyca/fides into jpople/ha-663/action-center-table-fixes
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes HA-663
Description Of Changes
Fixes a few UX issues with action center asset tables.
Screen.Recording.2025-05-06.at.11.11.07.mov
Before:

After:

Before:
Screen.Recording.2025-05-06.at.11.15.43.mov
After:
Screen.Recording.2025-05-06.at.11.17.30.mov
Steps to Confirm
Populate some web monitor results.
Row selection:
Cell padding:
Assign system modal:
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works