add support for empty SSL mode; change needed to connect with Google …#6123
Merged
add support for empty SSL mode; change needed to connect with Google …#6123
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6123 +/- ##
==========================================
- Coverage 86.88% 86.88% -0.01%
==========================================
Files 423 423
Lines 26109 26113 +4
Branches 2837 2838 +1
==========================================
+ Hits 22685 22688 +3
Misses 2807 2807
- Partials 617 618 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Removing file
tvandort
approved these changes
May 7, 2025
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 52s |
| Commit |
|
| Committer | JJ D'Aurora |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
jjdaurora
added a commit
that referenced
this pull request
May 8, 2025
16 tasks
jjdaurora
added a commit
that referenced
this pull request
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FIDES-1969
Description Of Changes
Write some things here about the changes and any potential caveats
Code Changes
Update the
get_connect_argsmethod inmysql_connector.pyto allow for setting an emptyconnect_argsparameter before it gets passed in to the create_engine methodUpdate MySQLSchema schema in connection_secrets_mysql.py to allow for saving an empty SSL Mode; add none="" enum
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works