Skip to content

add support for empty SSL mode; change needed to connect with Google …#6123

Merged
jjdaurora merged 7 commits intomainfrom
jjdaurora/FIDES-1969-v2
May 7, 2025
Merged

add support for empty SSL mode; change needed to connect with Google …#6123
jjdaurora merged 7 commits intomainfrom
jjdaurora/FIDES-1969-v2

Conversation

@jjdaurora
Copy link
Copy Markdown
Contributor

@jjdaurora jjdaurora commented May 6, 2025

Closes FIDES-1969

Description Of Changes
Write some things here about the changes and any potential caveats

Code Changes

  • Update the get_connect_args method in mysql_connector.py to allow for setting an empty connect_args parameter before it gets passed in to the create_engine method

  • Update MySQLSchema schema in connection_secrets_mysql.py to allow for saving an empty SSL Mode; add none="" enum

Steps to Confirm

  • Create a system and connect to any MySQL connection
  • Leave the SSL Mode empty and save the conncetion. The save should be successful without entering an SSL mode.
  • Click Test Integration. This step should also be successful, assuming the MySQL instance doesn't require SSL mode. In particular, this will work for a Google Cloud Proxy connection to MySQL.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 3:46pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 3:46pm

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (712e189) to head (1d6c0a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6123      +/-   ##
==========================================
- Coverage   86.88%   86.88%   -0.01%     
==========================================
  Files         423      423              
  Lines       26109    26113       +4     
  Branches     2837     2838       +1     
==========================================
+ Hits        22685    22688       +3     
  Misses       2807     2807              
- Partials      617      618       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jjdaurora jjdaurora merged commit a9d29ae into main May 7, 2025
40 checks passed
@jjdaurora jjdaurora deleted the jjdaurora/FIDES-1969-v2 branch May 7, 2025 16:11
@cypress
Copy link
Copy Markdown

cypress Bot commented May 7, 2025

fides    Run #12902

Run Properties:  status check passed Passed #12902  •  git commit a9d29ae507: Add support for empty SSL mode; change needed to connect with Google … (#6123)
Project fides
Branch Review main
Run status status check passed Passed #12902
Run duration 00m 52s
Commit git commit a9d29ae507: Add support for empty SSL mode; change needed to connect with Google … (#6123)
Committer JJ D'Aurora
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

jjdaurora added a commit that referenced this pull request May 8, 2025
@jjdaurora jjdaurora mentioned this pull request May 8, 2025
16 tasks
jjdaurora added a commit that referenced this pull request May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants