Skip to content

Fixes refresh/deep-link bug#6125

Merged
jpople merged 12 commits intomainfrom
jpople/ha-638/refresh-bug
May 7, 2025
Merged

Fixes refresh/deep-link bug#6125
jpople merged 12 commits intomainfrom
jpople/ha-638/refresh-bug

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented May 7, 2025

Closes HA-638

Description Of Changes

Fixes a bug where deep-linking and refreshing didn't work in production environments when certain characters (., [, ]) were present in the URL because the regex used for routing to static HTML files in didn't include them.

Steps to Confirm

Easiest way to test is to run a Fidesplus backend with a clean DB and the requirements pointed to this PR's alpha version. In prerelease_requirements.txt change your ethyca-fides version to:

ethyca-fides[all]==2.60.2a3

Then visit the admin UI at localhost:8080.

  1. Populate some web monitor results
  2. In the system aggregate table, click "uncategorized" results; note the URL contains [undefined]
  3. Refresh the page
  4. Should remain on the page
  5. View categorized results from a vendor; note the URL should contain a . in the vendor ID (e.g. fds.1210)
  6. Refresh the page
  7. Should remain on the page
  8. Test linking directly to either of the above pages by entering the URL (also test links containing hashes, e.g. #ignored)

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 5:01pm
fides-privacy-center 🛑 Canceled (Inspect) May 7, 2025 5:01pm

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.88%. Comparing base (69f10c3) to head (14ff54d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6125   +/-   ##
=======================================
  Coverage   86.88%   86.88%           
=======================================
  Files         423      423           
  Lines       26113    26113           
  Branches     2838     2838           
=======================================
  Hits        22689    22689           
  Misses       2807     2807           
  Partials      617      617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jpople jpople merged commit 3e6e316 into main May 7, 2025
16 of 17 checks passed
@jpople jpople deleted the jpople/ha-638/refresh-bug branch May 7, 2025 17:01
@cypress
Copy link
Copy Markdown

cypress Bot commented May 7, 2025

fides    Run #12906

Run Properties:  status check passed Passed #12906  •  git commit 3e6e316b36: Fixes refresh/deep-link bug (#6125)
Project fides
Branch Review main
Run status status check passed Passed #12906
Run duration 00m 51s
Commit git commit 3e6e316b36: Fixes refresh/deep-link bug (#6125)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants