Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6125 +/- ##
=======================================
Coverage 86.88% 86.88%
=======================================
Files 423 423
Lines 26113 26113
Branches 2838 2838
=======================================
Hits 22689 22689
Misses 2807 2807
Partials 617 617 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…/fides into jpople/ha-638/refresh-bug
andres-torres-marroquin
approved these changes
May 7, 2025
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes HA-638
Description Of Changes
Fixes a bug where deep-linking and refreshing didn't work in production environments when certain characters (
.,[,]) were present in the URL because the regex used for routing to static HTML files in didn't include them.Steps to Confirm
Easiest way to test is to run a Fidesplus backend with a clean DB and the requirements pointed to this PR's alpha version. In
prerelease_requirements.txtchange yourethyca-fidesversion to:Then visit the admin UI at localhost:8080.
[undefined].in the vendor ID (e.g.fds.1210)#ignored)Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works