Skip to content

Migrate last remaining Chakra icon button to Ant#6127

Merged
jpople merged 5 commits intomainfrom
jpople/ha-232/migrate-icon-button
May 7, 2025
Merged

Migrate last remaining Chakra icon button to Ant#6127
jpople merged 5 commits intomainfrom
jpople/ha-232/migrate-icon-button

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented May 7, 2025

Closes HA-232

Description Of Changes

Migrates an IconButton that was overlooked during the button migration to Ant.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 4:48pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 4:48pm

@jpople jpople merged commit 630686e into main May 7, 2025
16 of 17 checks passed
@jpople jpople deleted the jpople/ha-232/migrate-icon-button branch May 7, 2025 16:48
@cypress
Copy link
Copy Markdown

cypress Bot commented May 7, 2025

fides    Run #12904

Run Properties:  status check passed Passed #12904  •  git commit 630686e3fe: Migrate last remaining Chakra icon button to Ant (#6127)
Project fides
Branch Review main
Run status status check passed Passed #12904
Run duration 00m 54s
Commit git commit 630686e3fe: Migrate last remaining Chakra icon button to Ant (#6127)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants