Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
NevilleS
suggested changes
May 8, 2025
lucanovera
requested changes
May 9, 2025
Contributor
lucanovera
left a comment
There was a problem hiding this comment.
Good work! I left 1 suggestions for simplifying the code and a recommendation for using a library to handle the retry functionality.
NevilleS
suggested changes
May 9, 2025
Contributor
NevilleS
left a comment
There was a problem hiding this comment.
Ugh, I apologize for this "request changes", knowing that we're piling QoL asks onto a request that was originally fairly simple 👍
NevilleS
approved these changes
May 21, 2025
Contributor
NevilleS
left a comment
There was a problem hiding this comment.
This is great - we have some issues with the fides-privacy-center Vercel deployment, but that's almost certainly a red herring.
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | Tom Van Dort |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes FIDES-1977
Description Of Changes
Allow different empty experience fallback mechanisms.
Improve logging in Privacy Center.
Steps to Confirm
Observe that the PC 500s and logs per retry are listed.
Observe that everything works as it used to but
Observe that an empty experience is returned.
Observe that an empty experience is returned.
Adjust the log level to info and observe that there are no debug logs.
Observe that each log made during a HTTP request logs a request ID that is the same across messages.
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works