Refactor Fides initialization code#6143
Merged
gilluminate merged 4 commits intomainfrom May 14, 2025
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
d90edce to
d02cf23
Compare
eastandwestwind
approved these changes
May 14, 2025
Contributor
eastandwestwind
left a comment
There was a problem hiding this comment.
Really nice @gilluminate ! This reduces a lot of duplicate code and will reduce chance of bugs while working with this area 🌟
As far as I can see, this is a pure refactor, and no changes have been made as far as timing of when various parts of the init lifecycle happens. But correct me if I'm wrong there.
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 54s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Refactored Fides initialization code to reduce duplication and improve maintainability. Created a new utility file to centralize common initialization logic used across multiple Fides entry points.
Code Changes
lib/init-utils.tsfile to centralize common initialization functionsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works