Skip to content

Add discovery monitors queues#6144

Merged
vcruces merged 7 commits intomainfrom
datastore-monitor-celery
May 21, 2025
Merged

Add discovery monitors queues#6144
vcruces merged 7 commits intomainfrom
datastore-monitor-celery

Conversation

@vcruces
Copy link
Copy Markdown
Contributor

@vcruces vcruces commented May 13, 2025

Closes ENG-128

Description Of Changes

This PR adds support for new Celery queues specifically for discovery monitor operations in Fidesplus. These queues will handle detection, classification, and promotion tasks for monitors.

Code Changes

  • Added three new Celery queue names for datastore monitor operations:
    • fidesplus.discovery_monitors_detection - For running discovery monitors detection tasks
    • fidesplus.discovery_monitors_classification - For running discovery monitors classification tasks
    • fidesplus.discovery_monitors_promotion - For running discovery monitors promotion tasks
  • Updated queue counting functionality to include the new queues
  • Added the new queues to the worker initialization

Steps to Confirm

  • Verify that Celery workers can be started with the new queues

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 2:29pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 21, 2025 2:29pm

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (e9d7106) to head (10d4f05).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6144   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files         423      423           
  Lines       26158    26161    +3     
  Branches     2842     2842           
=======================================
+ Hits        22738    22741    +3     
  Misses       2800     2800           
  Partials      620      620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think we should communicate this to the ops team so we can make sure the Fides Cloud tenants get correctly set up to ignore the queues for now.

@vcruces vcruces force-pushed the datastore-monitor-celery branch from 0d7d5d7 to 10d4f05 Compare May 21, 2025 14:28
@vcruces vcruces merged commit 0d98a4a into main May 21, 2025
40 checks passed
@vcruces vcruces deleted the datastore-monitor-celery branch May 21, 2025 14:59
@cypress
Copy link
Copy Markdown

cypress Bot commented May 21, 2025

fides    Run #12935

Run Properties:  status check passed Passed #12935  •  git commit 0d98a4a295: Add discovery monitors queues (#6144)
Project fides
Branch Review main
Run status status check passed Passed #12935
Run duration 00m 50s
Commit git commit 0d98a4a295: Add discovery monitors queues (#6144)
Committer Victoria Cruces
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants