Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
03a3680 to
baae963
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6144 +/- ##
=======================================
Coverage 86.92% 86.92%
=======================================
Files 423 423
Lines 26158 26161 +3
Branches 2842 2842
=======================================
+ Hits 22738 22741 +3
Misses 2800 2800
Partials 620 620 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
443850a to
8b86ff3
Compare
e8d93a1 to
c3150d7
Compare
c3150d7 to
c5f18ba
Compare
erosselli
approved these changes
May 21, 2025
Contributor
erosselli
left a comment
There was a problem hiding this comment.
LGTM! I think we should communicate this to the ops team so we can make sure the Fides Cloud tenants get correctly set up to ignore the queues for now.
13a05ca to
0a76093
Compare
0d7d5d7 to
10d4f05
Compare
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | Victoria Cruces |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ENG-128
Description Of Changes
This PR adds support for new Celery queues specifically for discovery monitor operations in Fidesplus. These queues will handle detection, classification, and promotion tasks for monitors.
Code Changes
fidesplus.discovery_monitors_detection- For running discovery monitors detection tasksfidesplus.discovery_monitors_classification- For running discovery monitors classification tasksfidesplus.discovery_monitors_promotion- For running discovery monitors promotion tasksSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works