Skip to content

HA-686 - Fix cypress tests for integrations UI#6147

Merged
andres-torres-marroquin merged 5 commits intomainfrom
andres/HA-686
May 15, 2025
Merged

HA-686 - Fix cypress tests for integrations UI#6147
andres-torres-marroquin merged 5 commits intomainfrom
andres/HA-686

Conversation

@andres-torres-marroquin
Copy link
Copy Markdown
Contributor

@andres-torres-marroquin andres-torres-marroquin commented May 14, 2025

Closes HA-686

Description Of Changes

Fix cypress tests for integrations ui

Code Changes

  • Updated cypress files to handle connection_type intercepts correctly.
  • Added a tests splitter for Cypress-Admin-UI job

Steps to Confirm

  1. Look at the Cypress-Admin-UI job

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 3:21pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 3:21pm

import sys, os, json, math, re

# Number of groups to create (adjust based on your needs)
NUM_GROUPS = 3
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we can configure the number of jobs we are targeting to

Comment thread .github/workflows/cypress_admin-ui.yml Outdated
Admin-UI-Cypress:
needs: prepare-matrix
strategy:
fail-fast: false
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want all the jobs to run completely, we don't want one job on the matrix to stop the rest of them.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding this same message as a comment in the code for posterity

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (c37d2c9) to head (f024b8d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6147   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files         423      423           
  Lines       26150    26150           
  Branches     2840     2840           
=======================================
  Hits        22730    22730           
  Misses       2800     2800           
  Partials      620      620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andres-torres-marroquin andres-torres-marroquin changed the title HA-686 - Fix cypress tests for integrations ui HA-686 - Fix cypress tests for integrations UI May 15, 2025
Comment thread clients/admin-ui/cypress/e2e/integration-management.cy.ts Outdated
Comment thread .github/workflows/cypress_admin-ui.yml Outdated
Admin-UI-Cypress:
needs: prepare-matrix
strategy:
fail-fast: false
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding this same message as a comment in the code for posterity

Comment thread .github/workflows/cypress_admin-ui.yml Outdated
Comment thread clients/admin-ui/cypress/e2e/integration-management.cy.ts Outdated
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@andres-torres-marroquin andres-torres-marroquin merged commit d3fa103 into main May 15, 2025
47 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HA-686 branch May 15, 2025 17:25
@cypress
Copy link
Copy Markdown

cypress Bot commented May 15, 2025

fides    Run #12926

Run Properties:  status check passed Passed #12926  •  git commit d3fa103706: HA-686 - Fix cypress tests for integrations UI (#6147)
Project fides
Branch Review main
Run status status check passed Passed #12926
Run duration 00m 52s
Commit git commit d3fa103706: HA-686 - Fix cypress tests for integrations UI (#6147)
Committer Andrés Torres Marroquín
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants