Skip to content

Forms POC#6149

Merged
gilluminate merged 6 commits intomainfrom
gill/HJ-187/form-poc
May 15, 2025
Merged

Forms POC#6149
gilluminate merged 6 commits intomainfrom
gill/HJ-187/form-poc

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

Experiments for Formik vs Ant Form components

@gilluminate gilluminate requested a review from lucanovera May 15, 2025 16:41
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 5:58pm
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2025 5:58pm

@gilluminate gilluminate requested a review from jpople May 15, 2025 16:41
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR! This will be a good reference for new forms and/or changes to existing Formik forms. The cypress tests had a weird failure, it should be re-running now.

@gilluminate gilluminate merged commit 0543498 into main May 15, 2025
20 checks passed
@gilluminate gilluminate deleted the gill/HJ-187/form-poc branch May 15, 2025 18:18
@cypress
Copy link
Copy Markdown

cypress Bot commented May 15, 2025

fides    Run #12927

Run Properties:  status check passed Passed #12927  •  git commit 054349859f: Forms POC (#6149)
Project fides
Branch Review main
Run status status check passed Passed #12927
Run duration 00m 52s
Commit git commit 054349859f: Forms POC (#6149)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants