Add a new method to Fides object for updating user consent#6151
Add a new method to Fides object for updating user consent#6151gilluminate merged 17 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
682a7db to
9833156
Compare
7849008 to
9a99fa8
Compare
fbc736a to
f0f8d27
Compare
eastandwestwind
left a comment
There was a problem hiding this comment.
Couple small questions and requests. Looking great otherwise @gilluminate !
f75bdb8 to
301467e
Compare
301467e to
21a0034
Compare
8e1c419 to
c37d921
Compare
c37d921 to
248fae4
Compare
248fae4 to
35d3144
Compare
8d6231e to
ad840a4
Compare
| * - String values: | ||
| * - `"opt_in"` - user has explicitly opted in to this notice | ||
| * - `"opt_out"` - user has explicitly opted out of this notice | ||
| * - `"acknowledge"` - ONLY valid for notices with "notice_only" consent mechanism |
There was a problem hiding this comment.
do we also need to update this with "not_applicable" option too?
There was a problem hiding this comment.
Good callout. No, we don't want to support non_applicable but we do want to create an error specifically for that purpose that I forgot to add (see Neville's comment in JIRA https://ethyca.atlassian.net/browse/ENG-439?focusedCommentId=53324)
eastandwestwind
left a comment
There was a problem hiding this comment.
looks great! 1 small Q, non-blocking
| } | ||
|
|
||
| const handleValidationError = (errorMessage: string) => { | ||
| if (validation === "throw") { |
There was a problem hiding this comment.
can these be enums?
There was a problem hiding this comment.
good suggestion! I'll create a task in Jira for that so we don't hold up the release any longer. :)
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
Closes LJ-684
Description Of Changes
Added a new
updateConsentmethod to the Fides interface, allowing developers to programmatically update user consent preferences using either a consent object or fidesString.Code Changes
updateConsentfunction in preferences moduleupdateConsentmethodSteps to Confirm
6Sensevendor in Admin UI/fides-js-demo.html?geolocation=us-ut)fidesStringfidesStringtakes priority when both options are provided:Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works