ensure we show all frames in our profiler output#6153
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6153 +/- ##
=======================================
Coverage 86.92% 86.92%
=======================================
Files 423 423
Lines 26150 26150
Branches 2840 2840
=======================================
Hits 22730 22730
Misses 2800 2800
Partials 620 620 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erosselli
approved these changes
May 16, 2025
Contributor
erosselli
left a comment
There was a problem hiding this comment.
Thanks for this! I think we can add a Changelog entry under the Developer Experience section :)
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | Adam Sachs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
We're not showing all frames in our endpoint profiler output, which in practice seems to make that output pretty useless. This switch has the output show all frames - which can definitely be a bit verbose. But what's the point of profiling if it's not comprehensive? :)
Note: this was used to help find and confirm a potentially important performance improvement to our
GET /privacy experienceendpointCode Changes
show_all=Truein our profiler outputSteps to Confirm
profile-request: trueheader in any API calls against a fides webserverand includes useful information that shows our own function calls:
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works