Skip to content

Add UnverifiedIdentity class#6159

Merged
Linker44 merged 2 commits intomainfrom
LJ-600-error-pii-in-privacy-preferences
May 20, 2025
Merged

Add UnverifiedIdentity class#6159
Linker44 merged 2 commits intomainfrom
LJ-600-error-pii-in-privacy-preferences

Conversation

@Linker44
Copy link
Copy Markdown
Contributor

@Linker44 Linker44 commented May 20, 2025

Closes ENG-151

Description Of Changes

Added class to handle Unverified identitiies endpoint payloads

Code Changes

  • added new UnverifiedIdentity class that inherits from Identity

Steps to Confirm

  1. CI tests are passing

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 3:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 20, 2025 3:20pm

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (77db29c) to head (e299a99).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6159   +/-   ##
=======================================
  Coverage   86.92%   86.92%           
=======================================
  Files         423      423           
  Lines       26150    26158    +8     
  Branches     2840     2842    +2     
=======================================
+ Hits        22730    22738    +8     
  Misses       2800     2800           
  Partials      620      620           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests! Makes it easy to review, approved 👍

@Linker44 Linker44 merged commit 1974b09 into main May 20, 2025
40 checks passed
@Linker44 Linker44 deleted the LJ-600-error-pii-in-privacy-preferences branch May 20, 2025 19:33
@cypress
Copy link
Copy Markdown

cypress Bot commented May 20, 2025

fides    Run #12933

Run Properties:  status check passed Passed #12933  •  git commit 1974b09480: Add UnverifiedIdentity class (#6159)
Project fides
Branch Review main
Run status status check passed Passed #12933
Run duration 00m 52s
Commit git commit 1974b09480: Add UnverifiedIdentity class (#6159)
Committer Facundo Lopez Janza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants