Skip to content

LJ-399 Add ability to read and post internal comments to a privacy request#6165

Merged
lucanovera merged 34 commits intomainfrom
LJ-399-FE-Add-a-main-activity-view-for-viewing-and-adding-comments
May 29, 2025
Merged

LJ-399 Add ability to read and post internal comments to a privacy request#6165
lucanovera merged 34 commits intomainfrom
LJ-399-FE-Add-a-main-activity-view-for-viewing-and-adding-comments

Conversation

@lucanovera
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera commented May 22, 2025

Description Of Changes

Add ability to read and post internal comments to a privacy request

Code Changes

  • Added fetching of comments
  • Modified Activity Timeline component to show both comments & event logs, sorted by date
  • Added CommentInput component for posting new comments
  • Added new comments slice
  • Bonus change: Updated the clipboard icon to Carbon
  • Bonux fix: Fix formatDate displaying in 12hs format without saying if it's am or pm. Added am/pm to the formated text.

Steps to Confirm

You may use the lastest fidesplus if running locally, or use the vercel preview link.

  1. Login to admin ui, go to Request Manager and click on any request.
  2. Scroll down to the "Activity" tab to view the combined timeline of system events and comments.
  3. Click the "Add comment" button below the timeline.
  4. Enter text in the comment field and click "Save" to add an internal comment.
  5. Verify the comment appears in the Activity timeline, sorted chronologically with system events.
  6. Note that comments show author attribution correctly - username for root users, or first and last name for users with complete profiles.
  7. Click "Add comment" again, type some text, then click "Cancel" to verify cancellation works.
  8. Add another comment to see it appear at the appropriate position in the timeline.
  9. Refresh the page and confirm all previously added comments are still visible.
  10. Verify that system events and comments maintain proper chronological ordering in the timeline.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 29, 2025 0:44am
fides-privacy-center ⬜️ Ignored (Inspect) May 29, 2025 0:44am

Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well in testing. Tried to do some basic XSS injection attacks and none got through. Added a couple of suggestions for improvement.

…ain-activity-view-for-viewing-and-adding-comments
@lucanovera lucanovera merged commit e3ad603 into main May 29, 2025
20 checks passed
@lucanovera lucanovera deleted the LJ-399-FE-Add-a-main-activity-view-for-viewing-and-adding-comments branch May 29, 2025 13:00
@cypress
Copy link
Copy Markdown

cypress Bot commented May 29, 2025

fides    Run #12945

Run Properties:  status check passed Passed #12945  •  git commit e3ad6030a4: LJ-399 Add ability to read and post internal comments to a privacy request (#616...
Project fides
Branch Review main
Run status status check passed Passed #12945
Run duration 00m 52s
Commit git commit e3ad6030a4: LJ-399 Add ability to read and post internal comments to a privacy request (#616...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants