You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixed an issue where tables with both existing classified fields and new field discoveries would only show the "Confirm" action instead of "Monitor" in the Data detection view, preventing users from classifying newly discovered fields before promoting them to datasets.
Code Changes
Updated DetectionItemActionsCell to identify resources with classification changes and show "Monitor" button instead of "Confirm" for these scenarios
Added hasClassificationChanges logic to check for CLASSIFICATION_ADDITION or CLASSIFICATION_UPDATE in child diff statuses
Modified showStartMonitoringAction to include resources with classification changes
Modified showConfirmAction to exclude resources with classification changes
Added Cypress test coverage for the Monitor action on resources with classification changes
Fixed React error messages relating to attributes in MonitorOffIcon component
Steps to Confirm
Run detection on a schema with a table (see: Confluence docs)
Set up a discovery monitor and run detection on a schema with tables
Click "Monitor" on a table to send it to classification
After classification completes, add new fields to the table in the upstream datasource (see the Confluence docs above, toward the bottom of the page.)
Run detection again to discover the new fields
Verify that the table now shows a "Monitor" button in the Data detection view instead of "Confirm"
Click "Monitor" to classify the new fields before promoting the entire table
Pre-Merge Checklist
Issue requirements met
All CI pipelines succeeded
CHANGELOG.md updated
Add a
db-migrationThis indicates that a change includes a database migration
label to the entry if your change includes a DB migration
Add a
high-riskThis issue suggests changes that have a high-probability of breaking existing code
label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
Updates unreleased work already in Changelog, no new entry necessary
Followup issues:
Followup issues created
No followup issues
Database migrations:
Ensure that your downrev is up to date with the latest revision on main
Ensure that your downgrade() migration is correct and works
If a downgrade migration is not possible for this change, please call this out in the PR description!
If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
tested manually using the steps to repro on the ticket, and this is looking good! screenshot below shows the Monitor button on a table that is in the "mixed state" (some discovery/classification results, some new detection additions) showing the Monitor button while in the Data detection view. Clicking on that Monitor button correctly sent the net-new field that was an addition into classification, and eventually to the Data discovery view 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gilluminate
force-pushed
the
gill/ENG-126/cannot-monitor-classify-staged
branch
from
Failures
Flaky
Pending
Skipped
Passing
Closes ENG-126
Description of Changes
Fixed an issue where tables with both existing classified fields and new field discoveries would only show the "Confirm" action instead of "Monitor" in the Data detection view, preventing users from classifying newly discovered fields before promoting them to datasets.
Code Changes
DetectionItemActionsCellto identify resources with classification changes and show "Monitor" button instead of "Confirm" for these scenarioshasClassificationChangeslogic to check forCLASSIFICATION_ADDITIONorCLASSIFICATION_UPDATEin child diff statusesshowStartMonitoringActionto include resources with classification changesshowConfirmActionto exclude resources with classification changesMonitorOffIconcomponentSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works