Skip to content

Add pagination to integrations page#6184

Merged
lucanovera merged 5 commits intomainfrom
gill/ENG-28/integrations-pagination
Jun 2, 2025
Merged

Add pagination to integrations page#6184
lucanovera merged 5 commits intomainfrom
gill/ENG-28/integrations-pagination

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate commented May 29, 2025

Closes ENG-28

Description Of Changes

Added pagination support to the integrations list page in the Admin UI. When there are more than 10 integrations (smallest page size from default Ant Design Pagination component), users can now navigate through pages and adjust the page size using pagination controls at the bottom of the list (default is 50 per page)

Code Changes

  • Added AntPagination export to fidesui design system
  • Added pagination state management (page, pageSize) to integrations page with default page size of 50
  • Updated useGetAllDatastoreConnectionsQuery to accept pagination parameters (size, page)
  • Restructured data handling to use destructured items and total from API response
  • Added conditional pagination component below IntegrationList
  • Pagination includes size changer functionality and handles page/pageSize change events

Steps to Confirm

  1. Navigate to the integrations page in Admin UI
  2. Verify pagination controls appear when there are more than 10 integrations
  3. Test page navigation and page size changes work correctly
  4. Confirm integrations load properly for different pages
  5. Verify pagination controls are hidden when total items ≤ 10

CleanShot 2025-05-29 at 16 13 11@2x

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2025 2:37pm
fides-privacy-center ⬜️ Ignored (Inspect) Jun 2, 2025 2:37pm

@gilluminate gilluminate requested a review from jpople May 29, 2025 23:00
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Code changes look good. The new pagination is working correctly.
There's just a small bug, whenever a filter is changed (in this case the Tabs act as filters), we need to reset the page to the 1st page to avoid having an invalid page # and showing blank results.

Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. The small bug was fixed. Everything working as expected. Approved!

@lucanovera lucanovera merged commit d6c16bd into main Jun 2, 2025
20 checks passed
@lucanovera lucanovera deleted the gill/ENG-28/integrations-pagination branch June 2, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants