Add pagination to integrations page#6184
Merged
lucanovera merged 5 commits intomainfrom Jun 2, 2025
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
lucanovera
requested changes
May 30, 2025
Contributor
lucanovera
left a comment
There was a problem hiding this comment.
Good work! Code changes look good. The new pagination is working correctly.
There's just a small bug, whenever a filter is changed (in this case the Tabs act as filters), we need to reset the page to the 1st page to avoid having an invalid page # and showing blank results.
lucanovera
approved these changes
Jun 2, 2025
Contributor
lucanovera
left a comment
There was a problem hiding this comment.
Perfect. The small bug was fixed. Everything working as expected. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ENG-28
Description Of Changes
Added pagination support to the integrations list page in the Admin UI. When there are more than 10 integrations (smallest page size from default Ant Design Pagination component), users can now navigate through pages and adjust the page size using pagination controls at the bottom of the list (default is 50 per page)
Code Changes
AntPaginationexport tofidesuidesign systemuseGetAllDatastoreConnectionsQueryto accept pagination parameters (size, page)itemsandtotalfrom API responseIntegrationListSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works