Support selects and multiselects in integration forms#6190
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (79.00%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #6190 +/- ##
==========================================
- Coverage 87.07% 79.00% -8.08%
==========================================
Files 423 424 +1
Lines 26321 26343 +22
Branches 2870 2870
==========================================
- Hits 22919 20811 -2108
- Misses 2776 4875 +2099
- Partials 626 657 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lucanovera
left a comment
There was a problem hiding this comment.
Lots of great code cleanup here. The selectes/multiselects are working great from the Integrations page.
Strangely, I was not able to add the test connector from the Systems page:

And one small UI feedback from the Integrations setup is that the labels for some new fields look bigger than the others (compare Description with API Key):

…b.com/ethyca/fides into jpople/eng-629/integration-form-fixes
lucanovera
left a comment
There was a problem hiding this comment.
Performed regression testing on both integrations form, everything looks good, s3 select field works well. Approved!
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 53s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
Closes ENG-629
Description Of Changes
Adds support for select and multiselect fields on integration forms, either when
optionsare provided by the schema or when the expected value is an enum.Note none of our current live integrations actually have
optionsormultiselectin their schemas so I've added a dummy integration type in this PR for testing, but will remove it before merging. To test on a live integration you can use any schema that inherits from AWS (e.g. DynamoDB)-- the "authorization method" field should be a dropdown with two options.Code Changes
Steps to Confirm
/integrationsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works