Skip to content

Support selects and multiselects in integration forms#6190

Merged
jpople merged 29 commits intomainfrom
jpople/eng-629/integration-form-fixes
Jun 4, 2025
Merged

Support selects and multiselects in integration forms#6190
jpople merged 29 commits intomainfrom
jpople/eng-629/integration-form-fixes

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Jun 3, 2025

Closes ENG-629

Description Of Changes

Adds support for select and multiselect fields on integration forms, either when options are provided by the schema or when the expected value is an enum.

Screenshot 2025-06-03 at 11 11 23

Note none of our current live integrations actually have options or multiselect in their schemas so I've added a dummy integration type in this PR for testing, but will remove it before merging. To test on a live integration you can use any schema that inherits from AWS (e.g. DynamoDB)-- the "authorization method" field should be a dropdown with two options.

Code Changes

  • Refactors integration form in system integrations tab to use modern inputs
  • Support selects in integration forms

Steps to Confirm

  1. Create a system and go to the "Integrations" tab
  2. Select "Test Connector" in the integration type dropdown
  3. Form should populate with a mix of selects, multi-selects and text inputs
  4. Navigate to /integrations
  5. Click "add integration"
  6. Select "Test Connector" from the list
  7. Similarly, should see form populated with a mix of selects, multi-selects and text inputs

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 6:22pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-privacy-center ⬜️ Ignored (Inspect) Jun 4, 2025 6:22pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (d68efbc) to head (1c2ee87).

❌ Your project check has failed because the head coverage (79.00%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (d68efbc) and HEAD (1c2ee87). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (d68efbc) HEAD (1c2ee87)
12 10
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6190      +/-   ##
==========================================
- Coverage   87.07%   79.00%   -8.08%     
==========================================
  Files         423      424       +1     
  Lines       26321    26343      +22     
  Branches     2870     2870              
==========================================
- Hits        22919    20811    -2108     
- Misses       2776     4875    +2099     
- Partials      626      657      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great code cleanup here. The selectes/multiselects are working great from the Integrations page.
Strangely, I was not able to add the test connector from the Systems page:
Captura de pantalla 2025-06-04 a la(s) 11 39 14 a  m
And one small UI feedback from the Integrations setup is that the labels for some new fields look bigger than the others (compare Description with API Key):
Captura de pantalla 2025-06-04 a la(s) 11 40 46 a  m

Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed regression testing on both integrations form, everything looks good, s3 select field works well. Approved!

@jpople jpople merged commit bea58d4 into main Jun 4, 2025
20 checks passed
@jpople jpople deleted the jpople/eng-629/integration-form-fixes branch June 4, 2025 18:31
@cypress
Copy link
Copy Markdown

cypress Bot commented Jun 4, 2025

fides    Run #12962

Run Properties:  status check passed Passed #12962  •  git commit bea58d47ac: Support selects and multiselects in integration forms (#6190)
Project fides
Branch Review main
Run status status check passed Passed #12962
Run duration 00m 53s
Commit git commit bea58d47ac: Support selects and multiselects in integration forms (#6190)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants