Skip to content

Skip fetching of request comments if it's running OSS#6192

Merged
lucanovera merged 3 commits intomainfrom
fix-toast-on-fides-oss
Jun 4, 2025
Merged

Skip fetching of request comments if it's running OSS#6192
lucanovera merged 3 commits intomainfrom
fix-toast-on-fides-oss

Conversation

@lucanovera
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera commented Jun 4, 2025

Description Of Changes

Skip fetching of request comments if it's running OSS, preventing an error toast from showing up.

Code Changes

  • Skip fetching of request comments if it's running OSS

Steps to Confirm

  1. Go to the Privacy Request pages
  2. Click on any Privacy Request
  3. Check no error toast shows up

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2025 3:24pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-privacy-center ⬜️ Ignored (Inspect) Jun 4, 2025 3:24pm

Copy link
Copy Markdown
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, thanks for the quick fix!

@lucanovera lucanovera merged commit d68efbc into main Jun 4, 2025
20 checks passed
@lucanovera lucanovera deleted the fix-toast-on-fides-oss branch June 4, 2025 15:39
@cypress
Copy link
Copy Markdown

cypress Bot commented Jun 4, 2025

fides    Run #12958

Run Properties:  status check passed Passed #12958  •  git commit d68efbcbb3: Skip fetching of request comments if it's running OSS (#6192)
Project fides
Branch Review main
Run status status check passed Passed #12958
Run duration 00m 51s
Commit git commit d68efbcbb3: Skip fetching of request comments if it's running OSS (#6192)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants