Skip to content

ENG-693: Adds fides-client header to logs#6195

Merged
eastandwestwind merged 3 commits intomainfrom
ENG-693
Jun 5, 2025
Merged

ENG-693: Adds fides-client header to logs#6195
eastandwestwind merged 3 commits intomainfrom
ENG-693

Conversation

@eastandwestwind
Copy link
Copy Markdown
Contributor

@eastandwestwind eastandwestwind commented Jun 4, 2025

Closes https://ethyca.atlassian.net/browse/ENG-693

Description Of Changes

Adds fides-client header to logs so that we can start to discern traffic from mobile SDK vs web. Default is "unknown" for now, until we start to populate from various clients (mobile, privacy-center, etc)

Follow-up to pass in headers from mobile SDK is here- https://ethyca.atlassian.net/browse/ENG-679

Code Changes

  • Update our http log_request middleware to surface fides-client header

Steps to Confirm

  1. Start up server
  2. Confirm logs contain Fides-Client info, e.g. {'method': 'GET', 'status_code': 200, 'handler_time': '18.218ms', 'path': '/health', 'fides_client': 'unknown'}

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jun 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 9:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-privacy-center ⬜️ Ignored (Inspect) Jun 5, 2025 9:58am

Comment thread src/fides/api/main.py
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (ddbde7b) to head (e0b71ec).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6195   +/-   ##
=======================================
  Coverage   87.07%   87.07%           
=======================================
  Files         423      423           
  Lines       26321    26321           
  Branches     2870     2870           
=======================================
+ Hits        22919    22920    +1     
  Misses       2776     2776           
+ Partials      626      625    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eastandwestwind eastandwestwind merged commit b77c4f6 into main Jun 5, 2025
40 checks passed
@eastandwestwind eastandwestwind deleted the ENG-693 branch June 5, 2025 10:34
@cypress
Copy link
Copy Markdown

cypress Bot commented Jun 5, 2025

fides    Run #12965

Run Properties:  status check passed Passed #12965  •  git commit b77c4f6cb7: ENG-693: Adds fides-client header to logs (#6195)
Project fides
Branch Review main
Run status status check passed Passed #12965
Run duration 00m 53s
Commit git commit b77c4f6cb7: ENG-693: Adds fides-client header to logs (#6195)
Committer Catherine Smith
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants