ENG-693: Adds fides-client header to logs#6195
Merged
eastandwestwind merged 3 commits intomainfrom Jun 5, 2025
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
tvandort
requested changes
Jun 4, 2025
tvandort
approved these changes
Jun 4, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6195 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 423 423
Lines 26321 26321
Branches 2870 2870
=======================================
+ Hits 22919 22920 +1
Misses 2776 2776
+ Partials 626 625 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 53s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
tvandort
pushed a commit
that referenced
this pull request
Jun 6, 2025
erosselli
pushed a commit
that referenced
this pull request
Jun 12, 2025
erosselli
pushed a commit
that referenced
this pull request
Jun 12, 2025
erosselli
pushed a commit
that referenced
this pull request
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/ENG-693
Description Of Changes
Adds fides-client header to logs so that we can start to discern traffic from mobile SDK vs web. Default is "unknown" for now, until we start to populate from various clients (mobile, privacy-center, etc)
Follow-up to pass in headers from mobile SDK is here- https://ethyca.atlassian.net/browse/ENG-679
Code Changes
Steps to Confirm
Fides-Clientinfo, e.g.{'method': 'GET', 'status_code': 200, 'handler_time': '18.218ms', 'path': '/health', 'fides_client': 'unknown'}Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works