Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
tvandort
reviewed
Jun 6, 2025
Contributor
tvandort
left a comment
There was a problem hiding this comment.
Looks good to me! Were there any tests we wanted to add or update as part of this? If not I'm good to approve but I'd be remiss if I didn't ask.
tvandort
approved these changes
Jun 6, 2025
tvandort
added a commit
that referenced
this pull request
Jun 6, 2025
…gration (#6202) Co-authored-by: Tom Van Dort <tom@ethyca.com>
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
erosselli
pushed a commit
that referenced
this pull request
Jun 12, 2025
…gration (#6202) Co-authored-by: Tom Van Dort <tom@ethyca.com>
erosselli
pushed a commit
that referenced
this pull request
Jun 12, 2025
…gration (#6202) Co-authored-by: Tom Van Dort <tom@ethyca.com>
erosselli
pushed a commit
that referenced
this pull request
Jun 16, 2025
…gration (#6202) Co-authored-by: Tom Van Dort <tom@ethyca.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://ethyca.atlassian.net/browse/ENG-682
Description Of Changes
Currently we have an arbitrary 3000ms wait (3 secs) before loading Shopify. This change allows us to init Shopify early in init lifecycle, passing in defaults first, then updating as Fides completes initialization.
Code Changes
Steps to Confirm
fides-js-components-demo.html, add the following code after Fides init (L:220):http://localhost:3001/fides-js-components-demo.html, and open up consoleShopify customer privacy function calledimmediately afterFidesReadyevent.Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works