ENG-725 Add settings for read-only Redis and for test Redis index#6217
Merged
ENG-725 Add settings for read-only Redis and for test Redis index#6217
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
galvana
approved these changes
Jun 11, 2025
Contributor
galvana
left a comment
There was a problem hiding this comment.
Looks good! Aside from the embedded test code in _determine_redis_db_index which we already flagged for a follow up. Good test coverage here ✅
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (97.67%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6217 +/- ##
==========================================
+ Coverage 87.13% 87.14% +0.01%
==========================================
Files 433 433
Lines 26828 26863 +35
Branches 2932 2935 +3
==========================================
+ Hits 23376 23411 +35
Misses 2820 2820
Partials 632 632 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
945cb07 to
901bbf7
Compare
erosselli
commented
Jun 11, 2025
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 51s |
| Commit |
|
| Committer | erosselli |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ENG-725
Description Of Changes
Adds settings to be able to configure a read-only Redis instance, and a method to get this instance.
This also adds a
test_db_indexto be used when test mode is on.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works