ENG-1933: Add support for cookie deletion using wildcards#7047
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile OverviewGreptile SummaryAdds support for deleting cookies using wildcard patterns (e.g., Key changes:
Issue found: The regex pattern uses Confidence Score: 3/5
Important Files ChangedFile Analysis
|
|
@gilluminate ready for another look! The cookies on the notice that are coming from the website monitor will have the |
gilluminate
left a comment
There was a problem hiding this comment.
Approved with one very minor nitpick to prefer arrow functions
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Ticket ENG-1933
Description Of Changes
This PR adds support for deleting cookies using wildcards which will typically be the form of
prefix[id]or rarely[id]suffix. TheremoveCookiesFromBrowserfunction will now detect these, turn them into a regex pattern and use it to match cookies to be deleted. The attributes are ignored in this implementation sincejs-cookiedoesn't return them when getting all of the cookies, but this could be worked around with some additional complexity.Code Changes
removeCookiesFromBrowserfunctionPre-Merge Checklist
CHANGELOG.mdupdated