Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile OverviewGreptile SummaryThis PR upgrades React (19.0.0→19.0.1) and Next.js (15.2.3→15.2.6) to fix a React Server vulnerability, and adds logic to resurface the consent banner when users dismiss or reject consent in TCF overlays. Key Changes:
Minor Issues:
Confidence Score: 4/5
Important Files ChangedFile Analysis
|
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
clients/fides-js/__tests__/lib/consent-utils.test.ts, line 340 (link)style: Test label says "returns false" but expects
true- misleading label.
4 files reviewed, 2 comments
Comment on lines
+285
to
+290
| if ( | ||
| cookie.fides_meta.consentMethod === ConsentMethod.DISMISS || | ||
| cookie.fides_meta.consentMethod === ConsentMethod.REJECT | ||
| ) { | ||
| return true; | ||
| } |
Contributor
There was a problem hiding this comment.
style: Add test coverage for ConsentMethod.REJECT case - only DISMISS is tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2160
Description Of Changes
Custom alpha image for client. Includes updates in 2.75.2 plus Banner Resurfacing.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works