Update DSR notification UX by jack-gale-ethyca · Pull Request #7192 · ethyca/fides

jack-gale-ethyca · 2026-01-07T19:18:36Z

ENG-2303

Updates the privacy request error notification email template with new branding, improved copy, and enhanced UX in the notification configuration drawer.

Ticket ENG-2303

Description Of Changes

Updated DSR notification UX
Updated chakra components to ANT
Improved information architecture
Removed robotic language, made tone more conversational

Code Changes

Frontend (ConfigureAlerts.tsx)

Refactored to Ant Design: Migrated from Chakra UI to Ant Design components for consistency
UX improvements:
- Updated header to "Request notifications"
- Added description text at top (trimmed from original)
- Moved placeholder text to InfoTooltip
- Improved spacing and layout
- Buttons moved to footer with proper spacing

Email Input Component (EmailChipList.tsx)

Refactored to work with new Ant Design form structure
Simplified props interface (no longer requires Formik FieldArray)
Uses default tag color for email chips

Steps to Confirm

Email template renders correctly with new copy and branding from mailgun
All form validation and submission flows work correctly
Email is readable when forwarded to Slack (This is an known customer workflow, we should make sure the forwarded email in slack looks polished)

Pre-Merge Checklist

ENG-2303 Updates the privacy request error notification email template with new branding, improved copy, and enhanced UX in the notification configuration drawer.

vercel · 2026-01-07T19:18:40Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Jan 28, 2026 9:50pm

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
fides-privacy-center	Ignored		Jan 28, 2026 9:50pm

greptile-apps · 2026-01-07T19:20:59Z

Greptile Summary

This PR updates the DSR notification UX with improved branding and migrates the frontend from Chakra UI/Formik to Ant Design/React state.

Key changes:

Email template redesigned with Ethyca branding, responsive layout, and dark mode support
Backend now passes organization_name and company_logo_url to templates (previously missing unsent_errors)
Frontend refactored from Formik to React state management with Ant Design components

Critical issue:

The ConfigureAlerts drawer no longer loads existing notification settings from the API. When users open the drawer, they always see empty defaults instead of their current configuration. This breaks the edit flow.

Confidence Score: 3/5

Not safe to merge - breaks existing notification configuration editing
The PR contains a critical functional regression where users cannot view or edit their existing notification settings. The drawer always shows defaults instead of loading current values from the API.
ConfigureAlerts.tsx needs the data loading logic restored before merge

Important Files Changed

Filename	Overview
clients/admin-ui/src/features/privacy-requests/drawers/ConfigureAlerts.tsx	Migrated from Formik/Chakra to React state/Ant Design, but loses ability to load existing notification settings
src/fides/api/service/messaging/message_dispatch_service.py	Added support for optional organization_name and company_logo_url variables, fixed unsent_errors bug
src/fides/api/email_templates/templates/privacy_request_error_notification.html	Complete redesign with Ethyca branding, improved styling, responsive design, and dark mode support

greptile-apps

_{6 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

clients/admin-ui/src/features/privacy-requests/drawers/ConfigureAlerts.tsx

If you saved an email, then closed and reopened the tray, the email would disappear. this Fixes that.

jack-gale-ethyca · 2026-01-07T19:27:06Z

@galvana There is technically a BE change here, cursor found a bug and updated it. If we don't want to include that we don't have to. LMK.

ConfigureAlerts.tsx: Reorganized UI: global "Enable email notifications" toggle at top (defaults to ON) Updated copy: "Email addresses", "Send notification after [N] error(s)" with help text Form resets to defaults when drawer closes Split useEffect: one for query enable, one for data population Replaced div separators with Divider component Added array safety check to prevent dummy emails EmailChipList.tsx: Added disabled prop support Disables input and prevents email removal when disabled ProtectedRoute.tsx: Removed "/" from REDIRECT_IGNORES to fix 404 — unauthenticated users now redirect to login Result: Clearer UX with notifications enabled by default, threshold controls frequency, and no dummy emails pre-seeded.

galvana · 2026-01-12T20:33:56Z

Hey @jack-gale-ethyca what was the BE bug that Cursor found?

jack-gale-ethyca · 2026-01-12T20:40:45Z

@galvana

The PUT endpoint for updating privacy request notifications was inconsistent: it used a hardcoded ", " to split email addresses, while the GET endpoint used the EMAIL_JOIN_STRING constant. This could cause issues if the constant changed and made the code harder to maintain.

Code Changes Made
The fix changed line 735 in src/fides/api/api/v1/endpoints/privacy_request_endpoints.py:

Before:
return PrivacyRequestNotificationInfo( email_addresses=info.email.split(", "), # ❌ Hardcoded string notify_after_failures=info.notify_after_failures,)

After:
return PrivacyRequestNotificationInfo( email_addresses=info.email.split(EMAIL_JOIN_STRING), # ✅ Uses constant notify_after_failures=info.notify_after_failures,)

This aligns the PUT endpoint with the GET endpoint (line 674), which already used EMAIL_JOIN_STRING, ensuring consistent behavior and maintainability.

Curious if you agree?

Removed all BE code, redirects, etc. Simplifies the privacy request error notification email template to plain text copy, removing all styling, branding, and HTML structure. Changes Removed all CSS styling and complex HTML structure Removed branding elements (logos, banners, footer) Removed test email functionality Simplified to minimal HTML with plain text copy only Updated email copy to the new messaging Rationale Mailgun handles header, footer, and formatting. The template now provides only the email body copy, allowing Mailgun to apply consistent branding and styling. Email Copy The template now contains: Subject: Important information about your privacy request Body: Notification about processing issues and guidance to review in the admin dashboard This change ensures Mailgun can properly inject branding and formatting while maintaining the required notification content.

Made sure the description copy styling is consistent

ENG-2303 Updates the privacy request error notification email template with new branding, improved copy, and enhanced UX in the notification configuration drawer.

If you saved an email, then closed and reopened the tray, the email would disappear. this Fixes that.

Co-authored-by: 3nder <speaker_ender@protonmail.com>

Co-authored-by: Adrian Galvan <adrian@ethyca.com>

…reAlerts.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>

- Fix import sorting in ConfigureAlerts.tsx - Fix Prettier formatting (multiline to single line) - Fix Tailwind classnames order - Add changelog/7192.yaml entry

gilluminate

Code looks good overall! Nice work. There is one remaining bug I'm seeing, however. If there are email addresses saved, but the user clicks the Cancel button...reopening the drawer shows no email addresses saved. It seems to clear the field instead of restoring original values.

gilluminate

Working great now. Nice work!

Update DSR notification UX

6a0d0a8

ENG-2303 Updates the privacy request error notification email template with new branding, improved copy, and enhanced UX in the notification configuration drawer.

jack-gale-ethyca requested review from a team as code owners January 7, 2026 19:18

jack-gale-ethyca requested review from galvana and lucanovera and removed request for a team January 7, 2026 19:18

Update CHANGELOG.md

581de5c

greptile-apps bot reviewed Jan 7, 2026

View reviewed changes

clients/admin-ui/src/features/privacy-requests/drawers/ConfigureAlerts.tsx Show resolved Hide resolved

clients/admin-ui/src/features/privacy-requests/drawers/ConfigureAlerts.tsx Outdated Show resolved Hide resolved

Saved emails now persist

2eb3522

If you saved an email, then closed and reopened the tray, the email would disappear. this Fixes that.

vercel bot had a problem deploying to Preview – fides-plus-nightly January 7, 2026 19:28 Failure

vercel bot had a problem deploying to Preview – fides-plus-nightly January 12, 2026 15:29 Failure

Merge branch 'main' into ENG-2303

8460f88

vercel bot had a problem deploying to Preview – fides-plus-nightly January 12, 2026 20:34 Failure

jack-gale-ethyca added 3 commits January 16, 2026 17:06

Updated tray styling

d84e04b

Made sure the description copy styling is consistent

Revert changes to messaging.py

e849a9b

vercel bot had a problem deploying to Preview – fides-plus-nightly January 20, 2026 17:19 Failure

jack-gale-ethyca and others added 6 commits January 20, 2026 12:37

Update DSR notification UX

39ea8fd

ENG-2303 Updates the privacy request error notification email template with new branding, improved copy, and enhanced UX in the notification configuration drawer.

Update CHANGELOG.md

57eb0b8

Saved emails now persist

f41c6a2

If you saved an email, then closed and reopened the tray, the email would disappear. this Fixes that.

Remove incorrect async engine keepalive settings (#7171)

abe5c93

ENG-2274 FE copy updates (#7185)

b9a08ee

Co-authored-by: 3nder <speaker_ender@protonmail.com>

Python 3.13 🚂 (#7096)

c67fc58

Co-authored-by: Adrian Galvan <adrian@ethyca.com>

jack-gale-ethyca and others added 9 commits January 28, 2026 10:00

Update clients/admin-ui/src/features/privacy-requests/drawers/Configu…

fc16742

…reAlerts.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>

Update clients/admin-ui/src/features/privacy-requests/drawers/Configu…

011b4d2

…reAlerts.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>

Update clients/admin-ui/src/features/privacy-requests/drawers/Configu…

d4a704f

…reAlerts.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>

Update clients/admin-ui/src/features/privacy-requests/drawers/Configu…

9438292

…reAlerts.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>

Update clients/admin-ui/src/features/privacy-requests/drawers/Configu…

01b013a

…reAlerts.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>

Update clients/admin-ui/src/features/privacy-requests/drawers/Configu…

450d6cd

…reAlerts.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>

Update clients/admin-ui/src/features/privacy-requests/drawers/Configu…

1c7151a

…reAlerts.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>

Removed changelog.md updates

cda07e4

Merge branch 'ENG-2303' of https://github.com/ethyca/fides into ENG-2303

e90641a

vercel bot had a problem deploying to Preview – fides-plus-nightly January 28, 2026 15:07 Failure

Fix lint errors and add changelog entry

52fa89b

- Fix import sorting in ConfigureAlerts.tsx - Fix Prettier formatting (multiline to single line) - Fix Tailwind classnames order - Add changelog/7192.yaml entry

vercel bot deployed to Preview – fides-plus-nightly January 28, 2026 15:21 View deployment

gilluminate reviewed Jan 28, 2026

View reviewed changes

gilluminate self-requested a review January 28, 2026 16:56

Merge branch 'main' into ENG-2303

41ddd3c

vercel bot deployed to Preview – fides-plus-nightly January 28, 2026 18:18 View deployment

jack-gale-ethyca added 2 commits January 28, 2026 16:27

Fixed cancel bug

128abbc

Merge branch 'main' into ENG-2303

36b5a08

jack-gale-ethyca enabled auto-merge January 28, 2026 21:28

vercel bot deployed to Preview – fides-plus-nightly January 28, 2026 21:32 View deployment

jack-gale-ethyca added 2 commits January 28, 2026 16:45

Fixing FE failing checks

a384b49

Merge branch 'ENG-2303' of https://github.com/ethyca/fides into ENG-2303

6846928

vercel bot deployed to Preview – fides-plus-nightly January 28, 2026 21:50 View deployment

gilluminate removed request for galvana and lucanovera January 28, 2026 21:59

gilluminate approved these changes Jan 28, 2026

View reviewed changes

jack-gale-ethyca added this pull request to the merge queue Jan 28, 2026

Merged via the queue into main with commit d54470c Jan 28, 2026
46 checks passed

jack-gale-ethyca deleted the ENG-2303 branch January 28, 2026 22:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update DSR notification UX#7192

Update DSR notification UX#7192
jack-gale-ethyca merged 50 commits intomainfrom
ENG-2303

jack-gale-ethyca commented Jan 7, 2026 •

edited

Loading

Uh oh!

vercel bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Jan 7, 2026

Uh oh!

greptile-apps bot left a comment

Uh oh!

Uh oh!

Uh oh!

jack-gale-ethyca commented Jan 7, 2026

Uh oh!

galvana commented Jan 12, 2026

Uh oh!

jack-gale-ethyca commented Jan 12, 2026

Uh oh!

gilluminate left a comment

Uh oh!

gilluminate left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

jack-gale-ethyca commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Jan 7, 2026

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jack-gale-ethyca commented Jan 7, 2026

Uh oh!

galvana commented Jan 12, 2026

Uh oh!

jack-gale-ethyca commented Jan 12, 2026

Uh oh!

gilluminate left a comment

Choose a reason for hiding this comment

Uh oh!

gilluminate left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jack-gale-ethyca commented Jan 7, 2026 •

edited

Loading

vercel bot commented Jan 7, 2026 •

edited

Loading