Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jan 9, 2026

Ticket ENG-2318

Description Of Changes

Replaced the chakra checkbox that wasn't being updated visually with an Ant checkbox.

Code Changes

  • Replaced CustomCheckbox with ant checkbox in request manager and consent settings pages
  • Removed CustomCheckbox

Steps to Confirm

  1. Go to request manager page
  2. Click on Create request
  3. On the bottom of the modal, click the "I confirm that I have verified this user information" checkbox and confirm the checkbox visually changes to indicated it is checked
  4. Check the form validation works, ie the save button is disable unless you check that checkbox
  5. Visit the Settings > Consent page
  6. Select on of the GPP options (like Enable U.S. National)
  7. Confirm the "All transactions covered by MSPA" checkbox functions correctly and visually changes when checked

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Jan 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Jan 12, 2026 2:48pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Jan 12, 2026 2:48pm

@lucanovera lucanovera marked this pull request as ready for review January 9, 2026 17:50
@lucanovera lucanovera requested a review from a team as a code owner January 9, 2026 17:50
@lucanovera lucanovera requested review from jpople and removed request for a team January 9, 2026 17:50
@tvandort
Copy link
Contributor

tvandort commented Jan 9, 2026

@lucanovera I see one more use of CustomCheckbox in clients/admin-ui/src/features/consent-settings/GppConfiguration.tsx, should we remove it there and then delete CustomCheckbox?

@lucanovera
Copy link
Contributor Author

@lucanovera I see one more use of CustomCheckbox in clients/admin-ui/src/features/consent-settings/GppConfiguration.tsx, should we remove it there and then delete CustomCheckbox?

@tvandort Great catch! I've updated that other checkbox that presented the same bug and removed the component. Once we update those forms to Ant, we won't need the extra components I added.

@lucanovera lucanovera enabled auto-merge January 12, 2026 14:43
@lucanovera lucanovera added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit 12d98e4 Jan 12, 2026
45 checks passed
@lucanovera lucanovera deleted the ENG-2318-Fix-create-new-request-modal-checkbox branch January 12, 2026 15:07
lucanovera added a commit that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants