Add FidesLocaleUpdated event to monitor locale changes and improve documentation#7234
Merged
gilluminate merged 10 commits intomainfrom Jan 27, 2026
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
0458ed8 to
0f19917
Compare
tvandort
reviewed
Jan 16, 2026
3d43f5b to
3539ba4
Compare
gilluminate
commented
Jan 16, 2026
| window.Fides.locale = bestLocale; | ||
| setFidesGlobal(window.Fides as InitializedFidesGlobal); |
Contributor
Author
There was a problem hiding this comment.
This got missed when we first implemented the min/full experience split on TCF.
5de2f2e to
c1324ab
Compare
Contributor
Greptile SummaryThis PR adds a new Key changes:
Confidence Score: 5/5
Important Files Changed
|
587d540 to
61f954d
Compare
jpople
approved these changes
Jan 27, 2026
Contributor
jpople
left a comment
There was a problem hiding this comment.
Tested locally, link label is correct based on browser location and updates as expected. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: ENG-1780
Description
Previously, the recommended pattern would result in the modal link label not updating when users changed their language preference. Adds
FidesLocaleUpdatedevent to support this. UpdatedgetModalLinkLabel()documentation and implementation to properly handle locale changes.Even though "fides-modal-link" has always been our default value for
modalLinkID, it never showed up that way inFides.options. This PR also updates the way we set that default to be more accessible to customers.Several other race condition fixes to ensure locale is respected during and after page load.
Code Changes
FidesLocaleUpdatedevent that fires during pageload and when locale changesLanguageSelectorcomponent to dispatch locale change eventsmodalLinkIdtype fromstring | nulltostringwith default valueSteps to Confirm