Filter GPP notices from TCF experience options#7274
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
8293530 to
e27fbd8
Compare
clients/admin-ui/src/features/privacy-experience/PrivacyExperienceForm.tsx
Outdated
Show resolved
Hide resolved
a0e1faf to
efb4efd
Compare
979a1cd to
910402f
Compare
910402f to
b809448
Compare
Greptile OverviewGreptile SummaryThis PR adds validation to prevent GPP (Global Privacy Platform) notices from being configured in TCF (Transparency and Consent Framework) experiences, improving data integrity for consent management. Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files Changed
|
Additional Comments (1)
Consider preserving existing non-GPP notices: |
There was a problem hiding this comment.
Good job improving the experience and communicating more clearly to the user what options we support. During testing I saw:
- Disabled option ✅
- If a TCF experience has existing GPP notices configured, verify an error alert is displayed
⚠️
The alert shows correctly, but I noticed the GPP option I added previously shows the ID instead of the name. I think this is a bug because it defeats the purpose of the alert, as I can't reliable know what notices I'm deleting.
- non-TCF experiences still show all privacy notices ✅
PS: I updated the branch to pull the latest from main (without conflicts).
39a3c73 to
ed0ac72
Compare
|
@lucanovera good call! Updated now, please check again. |
lucanovera
left a comment
There was a problem hiding this comment.
confirmed the issue is solved.
Ticket ENG-1237
Description Of Changes
Added validation and UI improvements to prevent GPP notices from being configured in TCF experiences. When GPP notices are detected in a TCF experience, an error alert is displayed. The privacy notice dropdown now filters out GPP notices for TCF experiences and shows a disabled placeholder option to inform users that GPP notices are not supported.
Code Changes
ScrollableListcomponent to support disabled items viaisItemDisabledproppopupMatchSelectWidth={false}) to display longer option names without ellipsisoptionFilterProp="label"Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated