Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile OverviewGreptile SummaryThis PR implements field deletion preservation for SaaS datasets by preventing deletion of fields that are referenced in the SaaS configuration. Key Changes:
Testing:
Confidence Score: 5/5
Important Files Changed
|
| @@ -0,0 +1,4 @@ | |||
| type: Changed | |||
| description: Customers field deletion are now preserved when merging datasets. | |||
Contributor
There was a problem hiding this comment.
Grammatical error: "Customers field deletion are" should be "Customer field deletions are"
Suggested change
| description: Customers field deletion are now preserved when merging datasets. | |
| description: Customer field deletions are now preserved when merging datasets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2247
Description Of Changes
Previously if a customer deleted a field (that was not added by them) from the dataset our merge logic would revert that change. This was because we didnt want customers breaking their configuration since many dataset fields are referenced in the saas config and are needed for traversal.
On merge logic we now iterate through the whole saas_config and grab any dataset reference we can find. This is later used as a safeguard to prevent deletion of "protected fields". Customers are now able to delete any field as long as its not protected.
Code Changes
Steps to Confirm
/api/v1/connector-templates/{connector_template_type}/configto see the saas config./api/v1/connection/{connection_key}/datasetto edit the dataset, delete a field that is used as dataset reference on the saas config, delete a field that isnt referenced by the saas config.Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works