Add Cypress tests for fidesString overriding existing cookie#7290
Merged
gilluminate merged 2 commits intomainfrom Feb 3, 2026
Merged
Add Cypress tests for fidesString overriding existing cookie#7290gilluminate merged 2 commits intomainfrom
gilluminate merged 2 commits intomainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile OverviewGreptile SummaryThis PR adds comprehensive Cypress test coverage for verifying that Changes Made
Test QualityThe tests follow established patterns in the codebase and provide good coverage of the fidesString override behavior. The test implementation is thorough, checking multiple aspects:
File Size ConsiderationThe test file Confidence Score: 4/5
Important Files Changed
|
c539fdc to
604ed09
Compare
jpople
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2487
Description Of Changes
Add comprehensive Cypress tests to verify that
fidesString(notice consent string) correctly overrides existing cookie values during FidesJS initialization.Code Changes
Steps to Confirm
consent-banner.cy.tsPre-Merge Checklist
CHANGELOG.mdupdated