Skip to content

Updating db_dataset.yml#7310

Merged
galvana merged 1 commit intomainfrom
db-dataset
Feb 4, 2026
Merged

Updating db_dataset.yml#7310
galvana merged 1 commit intomainfrom
db-dataset

Conversation

@galvana
Copy link
Contributor

@galvana galvana commented Feb 4, 2026

Description Of Changes

Updating db_dataset.yml to include the new chat_config table.

Steps to Confirm

  1. CI checks should pass

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Feb 4, 2026 7:07pm
fides-privacy-center Ignored Ignored Feb 4, 2026 7:07pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 4, 2026

Greptile Overview

Greptile Summary

This PR adds the chat_config table definition to the database dataset YAML file, which is required for Fides' privacy scanning and data mapping capabilities.

The addition:

  • Includes all 12 fields from the ChatConfig model (including inherited Base class fields)
  • Fields are properly ordered alphabetically
  • All fields have appropriate descriptions
  • Data categories are correctly assigned (system.operations for config fields, user.contact.email for the email field)
  • Sensitive fields (access_token, client_secret, signing_secret) are noted as encrypted in their descriptions
  • Table placement is correct alphabetically between audit_log_resource and comment

This change is part of PR #7297 which introduced chat provider integration functionality.

Confidence Score: 5/5

  • This PR is safe to merge with no issues found
  • The dataset definition is complete, accurate, and follows all established conventions - all fields from the database model are present with appropriate descriptions and data categories
  • No files require special attention

Important Files Changed

Filename Overview
.fides/db_dataset.yml Added chat_config table with proper field definitions, descriptions, and data categories - all fields match the database model

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@galvana galvana added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit cfbc162 Feb 4, 2026
39 of 40 checks passed
@galvana galvana deleted the db-dataset branch February 4, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants