Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR migrates the build system from pip/setuptools/versioneer to uv/hatchling, modernizing the dependency management and build process. Major Changes:
Issues Found:
Notes:
Confidence Score: 3/5
Important Files Changed
|
scripts/print_version.py
Outdated
| try: | ||
| from importlib.metadata import version | ||
| import json | ||
| print(json.dumps({'version': version('ethyca_fides')})) |
There was a problem hiding this comment.
package name mismatch: pyproject.toml defines the package as ethyca-fides (with hyphen) but this script uses ethyca_fides (with underscore). When installed, Python packages normalize hyphens to underscores, so this should work, but verify this is intentional.
| print(json.dumps({'version': version('ethyca_fides')})) | |
| print(json.dumps({'version': version('ethyca-fides')})) |
scripts/print_version.py
Outdated
| except Exception: | ||
| import json | ||
| print(json.dumps({'version': 'unknown'})) |
There was a problem hiding this comment.
bare except Exception will silently hide all errors. Consider logging the error or being more specific about what exceptions to catch (e.g., PackageNotFoundError)
| except Exception: | |
| import json | |
| print(json.dumps({'version': 'unknown'})) | |
| except PackageNotFoundError: | |
| import json | |
| print(json.dumps({'version': 'unknown'})) |
scripts/print_version.py
Outdated
| from importlib.metadata import version | ||
| import json |
There was a problem hiding this comment.
imports should be at the top of the file per the custom rules, not inside try/except blocks
| from importlib.metadata import version | |
| import json | |
| from importlib.metadata import version, PackageNotFoundError | |
| import json | |
| try: | |
| print(json.dumps({'version': version('ethyca-fides')})) | |
| except PackageNotFoundError: | |
| print(json.dumps({'version': 'unknown'})) |
Context Used: Rule from dashboard - Python imports should always be placed at the top of the file, not near the code that uses them. (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
…standard python path library
|
Deployment failed with the following error: |
|
Deployment failed with the following error: |
adamsachs
left a comment
There was a problem hiding this comment.
this broadly looks good to me, thank you! very excited to upgrade our toolchain.
we were able to verify that we could:
- successfully publish our package: https://github.com/ethyca/fides/actions/runs/21890920811/job/63196292665, https://pypi.org/project/ethyca-fides/2.78.3a2/
- successfully publish our images: https://github.com/ethyca/fides/actions/runs/21883277029, https://hub.docker.com/layers/ethyca/fides/2.78.3a0/images/sha256-ac6595ca7685397d3c4fea210e203fce17c46c61e2f8a64ad57fa0a07a105351
i also verified that referenced uv commands in the repo work well for me locally.
i'm sure there will be some quirks and things we've broken, but i think this is good enough to go, and we'll adjust/fix as those come up 👍
🚢 🚢 🚢
This switches us from pip / setuptools / versioneer to uv / hatchling; creating a PR to ensure things run in CI as expected