Skip to content

ENG-2532 Fix Data Steward filter to use label instead of uuid#7329

Merged
nrxsmith merged 2 commits intomainfrom
nsmith/data-steward-field-fix
Feb 6, 2026
Merged

ENG-2532 Fix Data Steward filter to use label instead of uuid#7329
nrxsmith merged 2 commits intomainfrom
nsmith/data-steward-field-fix

Conversation

@nrxsmith
Copy link
Contributor

@nrxsmith nrxsmith commented Feb 6, 2026

Ticket ENG-2532

Description Of Changes

This fixes the Data Steward dropdown so it filters by label instead of the UUID.

Code Changes

  • Add filter prop to generic and website monitor forms

Steps to Confirm

  1. Create a new integration (website or generic, for example, an Okta monitor)
  2. Create a couple users
  3. Start creating a monitor on the integration; check the /users response for the UUIDs and usernames when the form opens.
  4. Type text matching the UUIDs, it shouldn't match
  5. Type text matching the username, it SHOULD match.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@nrxsmith nrxsmith requested a review from a team as a code owner February 6, 2026 00:01
@nrxsmith nrxsmith requested review from gilluminate and removed request for a team February 6, 2026 00:01
@vercel
Copy link
Contributor

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 6, 2026 2:35am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 6, 2026 2:35am

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 6, 2026

Greptile Overview

Greptile Summary

This PR fixes the Data Steward dropdown filter in both the generic and website monitor configuration forms. Previously, the Select component filtered by the value field (user UUID) instead of the label field (formatted user name). The fix adds optionFilterProp="label" to both Select components, enabling users to search by username, email, or full name rather than UUIDs.

The change is minimal and follows the existing pattern used in other Select components throughout the codebase (VendorSelector, TaxonomySelect, PrivacyNoticeTranslationForm). Both files received identical one-line changes to their respective Data Steward Select components.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The change is minimal (2 lines across 2 files), follows established patterns in the codebase, and only adds a single prop to existing Select components to fix a UX issue with filtering
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/integrations/configure-monitor/ConfigureMonitorForm.tsx Added optionFilterProp="label" to Data Steward Select component to enable filtering by user name instead of UUID
clients/admin-ui/src/features/integrations/configure-monitor/ConfigureWebsiteMonitorForm.tsx Added optionFilterProp="label" to Data Steward Select component to enable filtering by user name instead of UUID

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@nrxsmith nrxsmith changed the title Fix Data Steward filter to use label instead of uuid ENG-2532 Fix Data Steward filter to use label instead of uuid Feb 6, 2026
@speaker-ender
Copy link
Contributor

@nrxsmith i think there is a 3rd in clients/admin-ui/src/features/data-discovery-and-detection/action-center/forms/MonitorListSearchForm.tsx
tbh the default behavior for the select component is odd. I can see it being useful in addition to searching for the label value but not so much purely by value.

@nrxsmith
Copy link
Contributor Author

nrxsmith commented Feb 6, 2026

@nrxsmith i think there is a 3rd in clients/admin-ui/src/features/data-discovery-and-detection/action-center/forms/MonitorListSearchForm.tsx tbh the default behavior for the select component is odd. I can see it being useful in addition to searching for the label value but not so much purely by value.

I can update that one.

@nrxsmith nrxsmith added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2026
@nrxsmith nrxsmith added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit d5d82b2 Feb 6, 2026
45 of 46 checks passed
@nrxsmith nrxsmith deleted the nsmith/data-steward-field-fix branch February 6, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants