Skip to content

fix: monitor list ellipsis#7334

Merged
speaker-ender merged 1 commit intomainfrom
fix/monitor-list-ellipsis
Feb 7, 2026
Merged

fix: monitor list ellipsis#7334
speaker-ender merged 1 commit intomainfrom
fix/monitor-list-ellipsis

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 6, 2026

Ticket []

Description Of Changes

Fixes an issue where ellipsis did not work correctly in the monitor list date/time "column"

Code Changes

Steps to Confirm

  1. Visit the action center
  2. Confirm that the date/time value no longer has a hard cut off and has an ellipsis if too long

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 6, 2026 8:37pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 6, 2026 8:37pm

Request Review

@speaker-ender speaker-ender marked this pull request as ready for review February 6, 2026 20:38
@speaker-ender speaker-ender requested a review from a team as a code owner February 6, 2026 20:38
@speaker-ender speaker-ender requested review from jpople and removed request for a team February 6, 2026 20:38
@jack-gale-ethyca jack-gale-ethyca self-requested a review February 6, 2026 20:40
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 6, 2026

Greptile Overview

Greptile Summary

  • Adjusts the Action Center monitor list rendering to address truncation of the “Last scan” date/time by wrapping the Text node in an overflow-hidden container.
  • Change is localized to MonitorResult.tsx and affects only the UI layout for the last-monitored column.
  • Current implementation may still not show a true ellipsis, since the width/overflow constraint is applied to the wrapper rather than the Text element that owns ellipsis.

Confidence Score: 4/5

  • This PR is likely safe to merge but may not fully fix the UI behavior it targets.
  • The change is small and isolated to a single React component, with low blast radius. Main concern is functional: the new wrapper/container layout can clip text without producing an ellipsis glyph, so the reported UX bug may persist in some layouts/browsers.
  • clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResult.tsx

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResult.tsx Wraps the monitor last-scan Text in an overflow-hidden div to try to restore ellipsis; current structure likely clips without rendering the ellipsis because the width constraint is no longer on the Text element.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender added this pull request to the merge queue Feb 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 6, 2026
@speaker-ender speaker-ender added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit f031d11 Feb 7, 2026
45 of 46 checks passed
@speaker-ender speaker-ender deleted the fix/monitor-list-ellipsis branch February 7, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants