Skip to content

fix: activity center tab order#7376

Merged
speaker-ender merged 1 commit intomainfrom
fix/activity-center-tab-order
Feb 12, 2026
Merged

fix: activity center tab order#7376
speaker-ender merged 1 commit intomainfrom
fix/activity-center-tab-order

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 12, 2026

Ticket ENG-2680

Description Of Changes

Fixes the order of tabs in the activity center to show "Attention Required" before "Activity"

Code Changes

  • Updating the order of the menu items in the action center config const

Steps to Confirm

  1. Visit the activity center screen
  2. Verify that "Attention Required" is the first menu tab before "Activity"

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@speaker-ender speaker-ender requested a review from a team as a code owner February 12, 2026 17:27
@speaker-ender speaker-ender requested review from lucanovera and removed request for a team February 12, 2026 17:27
@vercel
Copy link
Contributor

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 12, 2026 5:33pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 12, 2026 5:33pm

Request Review

chore: add changelog
@speaker-ender speaker-ender force-pushed the fix/activity-center-tab-order branch from b133d3a to a13d288 Compare February 12, 2026 17:29
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

This PR reorders the tabs in the activity center to display "Attention Required" before "Activity". The change modifies the property order in the ACTION_CENTER_CONFIG object, swapping the positions of the two tab configurations.

The implementation relies on JavaScript's guaranteed preservation of object property insertion order (standardized in ES2015+), which is then extracted using Object.values() in ActionCenterLayout.tsx:46 to render the tabs in the correct order.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple property reordering in a configuration object. It affects only the visual tab order in the UI without introducing any logical changes, security concerns, or breaking modifications. Modern JavaScript (ES2015+) guarantees object property order preservation, making this a reliable approach.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useActionCenterNavigation.tsx Reordered object properties in ACTION_CENTER_CONFIG to show "Attention Required" tab before "Activity" tab

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the order is correct now.

@speaker-ender speaker-ender added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit 0e611dd Feb 12, 2026
45 checks passed
@speaker-ender speaker-ender deleted the fix/activity-center-tab-order branch February 12, 2026 19:17
speaker-ender added a commit that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants