Skip to content

fix chakra theme#7379

Merged
gilluminate merged 2 commits intomainfrom
gill/ENG-2637/checkboxes-in-locations
Feb 12, 2026
Merged

fix chakra theme#7379
gilluminate merged 2 commits intomainfrom
gill/ENG-2637/checkboxes-in-locations

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Feb 12, 2026

Ticket ENG-2637

Description Of Changes

Revert a change made when we reversed the export/import aliases in #7173

Code Changes

  • remove explicit chakra export of extendTheme and import the custom extendTheme

Steps to Confirm

  1. Checkboxes in Locations page are visible again

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 12, 2026 6:37pm
fides-privacy-center Ignored Ignored Feb 12, 2026 6:37pm

Request Review

@gilluminate gilluminate force-pushed the gill/ENG-2637/checkboxes-in-locations branch from f849a19 to 8c9f6b4 Compare February 12, 2026 18:37
@gilluminate gilluminate marked this pull request as ready for review February 12, 2026 18:45
@gilluminate gilluminate requested a review from a team as a code owner February 12, 2026 18:45
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

Reverted a breaking change from PR #7173 where extendTheme from @chakra-ui/react was exported as extendChakraTheme. This caused the admin-ui to use the raw Chakra extendTheme function instead of the custom wrapped version from fidesui that includes Fides-specific theme customizations (like checkbox color scheme defaults). The fix removes the problematic export from fidesui and updates admin-ui to import the custom extendTheme directly, restoring checkboxes and other themed components.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are a straightforward fix that correctly restores the intended theme behavior. The PR reverts an unintended breaking change by ensuring the custom extendTheme wrapper (which includes Fides theme defaults) is used instead of the raw Chakra function. This is a minimal, targeted fix with clear intent and no side effects.
  • No files require special attention

Important Files Changed

Filename Overview
changelog/chakra-theme-fix.yaml Added changelog entry documenting the theme fix
clients/admin-ui/src/theme/index.ts Changed import to use custom extendTheme instead of aliased Chakra version
clients/fidesui/src/index.ts Removed extendTheme as extendChakraTheme export that was breaking theme

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating and fixing the root issue

@gilluminate gilluminate added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit d7eb1da Feb 12, 2026
45 checks passed
@gilluminate gilluminate deleted the gill/ENG-2637/checkboxes-in-locations branch February 12, 2026 19:19
gilluminate added a commit that referenced this pull request Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants