Skip to content

fix: website monitor feature flag [ENG-2659]#7382

Merged
speaker-ender merged 1 commit intomainfrom
fix/website-monitor-feature-flag--2659
Feb 12, 2026
Merged

fix: website monitor feature flag [ENG-2659]#7382
speaker-ender merged 1 commit intomainfrom
fix/website-monitor-feature-flag--2659

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 12, 2026

Ticket ENG-2659

Description Of Changes

Fixes website monitors being displayed in root action center and integrations form

Code Changes

Steps to Confirm

  1. Start with web monitor flag enabled
  2. Create a website monitor and scan
  3. Disable website monitor flag
  4. Confirm that website monitor no longer displays in root action center
  5. Go to the integration screen and open the add new integration modal
  6. Confirm that you are not longer able to pick a website type of integration from the list of options

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@speaker-ender speaker-ender requested a review from a team as a code owner February 12, 2026 20:43
@speaker-ender speaker-ender requested review from jpople and removed request for a team February 12, 2026 20:43
@vercel
Copy link
Contributor

vercel bot commented Feb 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 12, 2026 9:06pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 12, 2026 9:06pm

Request Review

@speaker-ender speaker-ender force-pushed the fix/website-monitor-feature-flag--2659 branch 2 times, most recently from 783f116 to 6415bae Compare February 12, 2026 20:44
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Greptile Overview

Greptile Summary

Fixed website monitor feature flag to properly hide website-related UI when the webMonitor flag is disabled. The changes ensure website monitors don't appear in the action center and website integrations are filtered from the integrations form.

Key changes:

  • MonitorList.tsx: Updated filter to use availableMonitorTypes as default when no specific monitor type is selected
  • SelectIntegrationType.tsx: Added filtering to exclude website category and integrations when webMonitor flag is off
  • useIntegrationFilterTabs.tsx: Filters out website tab when webMonitor flag is disabled

Issues found:

  • Missing webMonitor dependency in useMemo hook (critical - causes stale closures)
  • Import path inconsistency in useIntegrationFilterTabs.tsx

Confidence Score: 3/5

  • This PR has a critical dependency array bug that will cause incorrect memoization behavior
  • The missing webMonitor dependency in the useMemo hook on line 142 of SelectIntegrationType.tsx is a critical bug that will prevent the filtered types from updating when the feature flag changes, causing stale closures and incorrect UI behavior. The logic otherwise looks correct for hiding website monitors.
  • Pay close attention to SelectIntegrationType.tsx - the missing dependency must be fixed before merging

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorList.tsx Fixed monitor type filtering to use all available monitor types when no specific type is selected
clients/admin-ui/src/features/integrations/add-integration/SelectIntegrationType.tsx Added webMonitor flag filtering to hide website category/integrations when flag is disabled
clients/admin-ui/src/features/integrations/useIntegrationFilterTabs.tsx Filters website tab from integration tabs when webMonitor flag is disabled

Last reviewed commit: 6415bae

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@@ -1,5 +1,6 @@
import { useState } from "react";

import { useFlags } from "~/features/common/features/features.slice";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inconsistent import path - use ~/features/common/features instead of ~/features/common/features/features.slice to match the pattern used in SelectIntegrationType.tsx and other files in the codebase

Suggested change
import { useFlags } from "~/features/common/features/features.slice";
import { useFlags } from "~/features/common/features";

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 12, 2026

Additional Comments (1)

clients/admin-ui/src/features/integrations/add-integration/SelectIntegrationType.tsx
missing webMonitor dependency - the filteredTypes memo depends on webMonitor flag but it's not in the dependency array

  }, [searchTerm, selectedCategory, webMonitor, allIntegrationTypes]);

chore: adding changelog

fix: filter logic

fix: dep
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me locally. However, there might a follow-up needed, since I can get to deep link website assets after the flag has been disabled. The following route still works: pages/data-discovery/action-center/website/[monitorId]/[systemId]/index.tsx. Since that's probably always been the case, it likely isn't super urgent.

@speaker-ender
Copy link
Contributor Author

This is working for me locally. However, there might a follow-up needed, since I can get to deep link website assets after the flag has been disabled. The following route still works: pages/data-discovery/action-center/website/[monitorId]/[systemId]/index.tsx. Since that's probably always been the case, it likely isn't super urgent.

Yes, I called out some other gaps as well that need to be closed at some point.

@speaker-ender speaker-ender added this pull request to the merge queue Feb 12, 2026
Merged via the queue into main with commit add2542 Feb 12, 2026
45 checks passed
@speaker-ender speaker-ender deleted the fix/website-monitor-feature-flag--2659 branch February 12, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants