fix: website monitor feature flag [ENG-2659]#7382
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
783f116 to
6415bae
Compare
Greptile OverviewGreptile SummaryFixed website monitor feature flag to properly hide website-related UI when the Key changes:
Issues found:
Confidence Score: 3/5
Important Files Changed
Last reviewed commit: 6415bae |
| @@ -1,5 +1,6 @@ | |||
| import { useState } from "react"; | |||
|
|
|||
| import { useFlags } from "~/features/common/features/features.slice"; | |||
There was a problem hiding this comment.
inconsistent import path - use ~/features/common/features instead of ~/features/common/features/features.slice to match the pattern used in SelectIntegrationType.tsx and other files in the codebase
| import { useFlags } from "~/features/common/features/features.slice"; | |
| import { useFlags } from "~/features/common/features"; |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Additional Comments (1)
|
chore: adding changelog fix: filter logic fix: dep
7ca4bf6 to
4ed2754
Compare
gilluminate
left a comment
There was a problem hiding this comment.
This is working for me locally. However, there might a follow-up needed, since I can get to deep link website assets after the flag has been disabled. The following route still works: pages/data-discovery/action-center/website/[monitorId]/[systemId]/index.tsx. Since that's probably always been the case, it likely isn't super urgent.
Yes, I called out some other gaps as well that need to be closed at some point. |
Ticket ENG-2659
Description Of Changes
Fixes website monitors being displayed in root action center and integrations form
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works