ENG-2213: Remove deprecated DSR 2.0 code by galvana · Pull Request #7438 · ethyca/fides

galvana · 2026-02-20T00:51:20Z

Description Of Changes

Remove all deprecated DSR 2.0 code, making DSR 3.0 the sole execution path for data subject requests. DSR 2.0 was a sequential, in-memory execution model using Dask with Redis caching. It has been deprecated since DSR 3.0 (task-based async execution via RequestTasks) became the default.

This is a purely subtractive change — no new functionality is introduced. The use_dsr_3_0 fixture is kept as a no-op for backward compatibility with fidesplus tests.

Code Changes

Deleted modules:

src/fides/api/task/deprecated_graph_task.py - Core DSR 2.0 sequential execution logic
src/fides/api/task/scheduler_utils.py - DSR 2.0/3.0 routing logic (use_dsr_3_0_scheduler())

Deleted test files:

tests/ops/task/test_deprecated_graph_task.py
tests/ops/task/test_task_resources.py
tests/test_dsr_3_0_default.py

Simplified source files:

src/fides/api/task/graph_runners.py - Unconditionally delegates to DSR 3.0 and raises PrivacyRequestExit
src/fides/api/task/task_resources.py - Removed DSR 2.0 Redis caching methods (cache_results_with_placeholders, cache_object, get_all_cached_objects, cache_erasure, get_all_cached_erasures)
src/fides/api/task/graph_task.py - Removed DSR 2.0 caching calls and conditional blocks
src/fides/api/task/create_request_tasks.py - Received format_data_use_map_for_caching() relocated from deprecated_graph_task (still used by DSR 3.0)
src/fides/api/models/privacy_request/privacy_request.py - Removed DSR 2.0 Redis cache fallback paths
src/fides/api/graph/traversal.py - Removed to_mock_execution_node() (DSR 2.0 only)
.fides/redis_dataset.yml - Removed DSR 2.0 cache key documentation

Test updates (~40 files):

Removed use_dsr_2_0 fixture and all "use_dsr_2_0" parametrization
Removed dead if dsr_version == "use_dsr_2_0" conditional branches
Replaced get_cached_data_for_erasures(...) calls with {}
Converted use_dsr_3_0 to a no-op fixture for backward compatibility

Steps to Confirm

Verify nox -s static_checks passes (ruff check, ruff format, mypy)
Verify all imports resolve correctly: python -c "from fides.api.task.graph_runners import access_runner; from fides.api.task.create_request_tasks import format_data_use_map_for_caching"
Verify deleted modules are gone: python -c "import fides.api.task.deprecated_graph_task" should raise ImportError
Run DSR-related test suites in CI

Pre-Merge Checklist

Issue requirements met
All CI pipelines succeeded
CHANGELOG.md updated
- Updates unreleased work already in Changelog, no new entry necessary
UX feedback:
- No UX review needed
Followup issues:
- No followup issues
Database migrations:
- No migrations
Documentation:
- No documentation updates required

Made with Cursor

DSR 3.0 is now the only execution path. This removes the deprecated DSR 2.0 sequential/Dask-based execution model including: - deprecated_graph_task.py and scheduler_utils.py modules - Redis caching methods from TaskResources - DSR 2.0 fallback paths in privacy_request model methods - to_mock_execution_node() from traversal.py - use_dsr_2_0 test fixture and all DSR version parameterization - Deleted test files: test_deprecated_graph_task, test_task_resources, test_dsr_3_0_default Moved format_data_use_map_for_caching() to create_request_tasks.py as it is still used by DSR 3.0. Co-authored-by: Cursor <cursoragent@cursor.com>

vercel · 2026-02-20T00:51:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ready	Preview, Comment	Feb 26, 2026 10:58pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
fides-privacy-center	Ignored		Feb 26, 2026 10:58pm

Co-authored-by: Cursor <cursoragent@cursor.com>

- Restore to_mock_execution_node() on TraversalNode (used by test infrastructure, not DSR 2.0 execution) - Remove test_dsr_2_0 methods from test_request_task.py (tested deleted Redis cache fallback) - Remove test_scylladb_access_request_task_no_keyspace_dsr2 (the _dsr3 variant already covers this scenario) Co-authored-by: Cursor <cursoragent@cursor.com>

Restore the request_task.id check in GraphTask.update_status() to skip db.merge for in-memory mock RequestTask objects used by tests. Co-authored-by: Cursor <cursoragent@cursor.com>

The retry decorator no longer re-raises exceptions for non-persistent RequestTasks. Update test to verify the error is caught and logged rather than propagated. Co-authored-by: Cursor <cursoragent@cursor.com>

These tests called access_runner/erasure_runner directly which now always raise PrivacyRequestExit. Their docstrings noted the DSR 3.0 equivalents exist in test_create_request_tasks.py. Co-authored-by: Cursor <cursoragent@cursor.com>

DSR 3.0 is the only execution path. Remove all dsr_version/use_dsr_3_0 test parameterization, conditional DSR version logic, and the no-op use_dsr_3_0 fixture and config setting across 44 files. Co-authored-by: Cursor <cursoragent@cursor.com>

greptile-apps · 2026-02-21T09:14:04Z

Greptile Summary

This PR successfully removes all deprecated DSR 2.0 code, making DSR 3.0 the sole execution path for data subject requests. The changes are purely subtractive (3,737 deletions vs 537 additions), with the additions being primarily relocated code and test cleanup.

Key changes:

Deleted core DSR 2.0 modules: deprecated_graph_task.py (403 lines), scheduler_utils.py (53 lines)
Removed DSR 2.0 Redis caching methods from task_resources.py (5 methods)
Simplified graph_runners.py to unconditionally use DSR 3.0 and raise PrivacyRequestExit
Removed DSR 2.0 conditional logic throughout graph_task.py
Removed DSR 2.0 Redis cache fallbacks from privacy_request.py
Relocated format_data_use_map_for_caching() to create_request_tasks.py (still used by DSR 3.0)
Deleted 3 test files and removed dsr_version parametrization from ~40 test files
Removed use_dsr_2_0 and use_dsr_3_0 test fixtures (no longer needed)

PR description minor inaccuracy:
The description states "use_dsr_3_0 fixture is kept as a no-op for backward compatibility" but it was actually removed entirely in commit ecb4dad. This is the correct approach since no tests reference it anymore after the parametrization removal.

All imports have been verified clean - no references to deleted modules remain. The changes are well-structured and maintain backward compatibility where needed (DSR 3.0 execution path unchanged).

Confidence Score: 5/5

This PR is safe to merge - it's a clean removal of deprecated code with no new functionality
Score reflects the purely subtractive nature of the changes, thorough test cleanup, successful verification that no imports of deleted modules remain, and clear separation between DSR 2.0 (deleted) and DSR 3.0 (retained) code paths
No files require special attention - all changes follow expected patterns for deprecation removal

Important Files Changed

Filename	Overview
src/fides/api/task/deprecated_graph_task.py	Deleted entire deprecated DSR 2.0 sequential execution logic (403 lines). This was the core Dask-based in-memory execution model that has been replaced by DSR 3.0's task-based async execution.
src/fides/api/task/scheduler_utils.py	Deleted DSR 2.0/3.0 routing logic. The `use_dsr_3_0_scheduler()` function that determined which execution path to use is no longer needed.
src/fides/api/task/graph_runners.py	Simplified to only call DSR 3.0 functions and raise PrivacyRequestExit. Removed all DSR 2.0 conditional logic and imports of deprecated functions.
src/fides/api/task/task_resources.py	Removed 5 DSR 2.0 Redis caching methods: `cache_results_with_placeholders`, `cache_object`, `get_all_cached_objects`, `cache_erasure`, `get_all_cached_erasures`. Also removed cache instance variable.
src/fides/api/task/graph_task.py	Removed DSR 2.0 conditional caching logic throughout. Deleted `get_cached_data_for_erasures()` function. Simplified to only save data directly on RequestTask objects.
src/fides/api/task/create_request_tasks.py	Added `format_data_use_map_for_caching()` function relocated from deleted deprecated_graph_task.py. This function is still used by DSR 3.0.
src/fides/api/models/privacy_request/privacy_request.py	Removed DSR 2.0 Redis cache fallback logic from `get_raw_access_results()`, `get_raw_masking_counts()`, and `get_consent_results()`. Now only queries RequestTask data.
tests/ops/integration_tests/test_execution.py	Removed all `dsr_version` parametrization and conditional logic. Tests now only run with DSR 3.0. Reduced from ~800 to ~500 lines.
tests/ops/task/test_graph_task.py	Removed `TestUpdateErasureMappingFromCache` class (97 lines) testing DSR 2.0 erasure caching. Updated imports to use `format_data_use_map_for_caching` from create_request_tasks.

_{Last reviewed commit: 38ffb72}

greptile-apps

_{61 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

JadeCara

A few comments etc

This one is from claude - I think its reasobable though:

The || has lower precedence than &&, so if isVerificationRequired is false and data.succeeded is empty, data.succeeded[0].status === DUPLICATE will throw a TypeError. Fix: wrap the second branch in a
length guard.

(Pre-existing bug from PR #7238, but the surrounding code changes make this path more reachable.)

There are still a few docstrings where 3.0 is referenced. Do we want to keep that since it is TheWay ™️ now?
Codegraph found some dead code left over - please verify since I am still finding edges.

Codegraph Dead Code Report
Confirmed Dead Code (safe to delete)
Function: PrivacyRequest.get_results
Location: privacy_request.py:825
Callers: 0 callers
Impact (dependents): 0 dependents
Neighbourhood: Outbound only: calls get_cache() → FidesopsRedis. No inbound edges from any fides or fidesplus code.
Verdict: Dead code. Docstring even says "Just used in testing" but no tests call it anymore.
────────────────────────────────────────
Function: extract_key_for_address
Location: collection_util.py:107
Callers: 0 callers
Impact (dependents): 0 dependents
Neighbourhood: No neighbours at all (completely isolated node).
Verdict: Dead code. Total orphan - zero inbound, zero outbound connections.
────────────────────────────────────────
Function: start_function
Location: graph_task.py:936
Callers: 0 callers
Impact (dependents): 0 dependents
Neighbourhood: No neighbours at all (completely isolated node).
Verdict: Dead code. Was used for Dask graph seed nodes. Total orphan.

JadeCara · 2026-02-25T19:40:47Z

src/fides/api/task/graph_runners.py

-        raise PrivacyRequestExit()
-
-    return run_access_request_deprecated(
+    """Run an access request using DSR 3.0 task-based execution."""


Can we drop the 3.0 from the docstring here as well?

Done — removed "DSR 3.0" from all three runner docstrings in b5212b5.

JadeCara · 2026-02-25T19:42:11Z

tests/ops/integration_tests/test_enabled_actions.py

        self,
        db,
-        dsr_version,
        request,


I think its safe to remove this here now

Suggested change

request,

Investigated — these two tests cover live behavior (enabled_actions filtering on manual webhooks within run_privacy_request). No other integration test covers this path; the model-level unit test in test_manual_webhook.py only tests AccessManualWebhook.get_enabled() directly, not the full pipeline pause/skip. Kept the tests but removed the unused request fixture param left over from DSR version parameterization.

JadeCara · 2026-02-25T19:42:49Z

tests/ops/integration_tests/test_enabled_actions.py

        self,
        db,
-        dsr_version,
        request,


I think its safe to remove this here now as well.

Suggested change

request,

Same as above — kept the test since it covers unique behavior, but cleaned up the unused request fixture param.

JadeCara · 2026-02-25T19:55:48Z

tests/ops/integration_tests/test_enabled_actions.py

Stray 2.0 ref!

Removed in b5212b5.

JadeCara · 2026-02-25T19:57:56Z

tests/ops/integration_tests/test_execution.py

Stray 2.0 reference

Removed in b5212b5 — simplified to just "Restart from the checkpoint".

JadeCara · 2026-02-25T20:01:52Z

src/fides/api/task/graph_task.py

looks like this comment got cut off - we can probably remove the reference to 3.0 since that is TheWay ™️ now

Fixed — replaced the cut-off comment with "Saved as part of the request task" in b5212b5.

JadeCara · 2026-02-25T20:12:47Z

src/fides/api/task/graph_runners.py

I havent fully verified this admittedly - but claude and the graph called this out

Finding #7: Unused parameters — Confirmed erasure_runner — 5 unused params confirmed. graph_file for create_request_tasks.py shows run_erasure_request (line 646) has edges only to: - PrivacyRequest (REFERENCES) - RequestTask (REFERENCES) - queue_request_task (CALLS) - log_task_queued (CALLS) No edges to Policy, DatasetGraph, ConnectionConfig, or any identity-related node. The runner passes only privacy_request, session, and privacy_request_proceed — the other 5 params (policy, graph, connection_configs, identity, access_request_data) are accepted but never forwarded. consent_runner — 2 unused params confirmed. run_consent_request (line 669) has edges to: - DatasetGraph (REFERENCES) — uses graph param - PrivacyRequest (REFERENCES) - RequestTask (REFERENCES) - TraversalNode (CALLS) - get_connection_configs_with_manual_tasks (CALLS) — fetches its own configs - queue_request_task (CALLS) - log_task_queued (CALLS) No edges to Policy or ConnectionConfig. The runner accepts policy and connection_configs but never passes them through. access_runner — clean. run_access_request (line 539) references Policy, DatasetGraph, ConnectionConfig, PrivacyRequest, RequestTask, and Traversal — all params are used. Cross-repo impact: graph_context confirmed callers in fidesplus — erasure_runner_tester and consent_runner_tester in test helpers, plus ConnectorRunner methods. Any signature cleanup would need coordinated changes. --- Finding #8: Misleading return types — Confirmed All three runners unconditionally raise PrivacyRequestExit() after delegating to run_*_request. The declared return types are unreachable: - access_runner → Dict[str, List[Row]] (never returned) - erasure_runner → Dict[str, int] (never returned) - consent_runner → Dict[str, bool] (never returned) The test wrappers in tests/conftest.py (lines 930, 960, 989) catch PrivacyRequestExit and return actual results from the database, which is why tests still work. The return types on the runners themselves are vestigial from the DSR 2.0 era when these functions returned results directly. A more accurate signature would be -> NoReturn from typing, since the functions always raise. --- Both findings are solid and codegraph-verified. Neither is a bug per se — they're cleanup opportunities left behind by the DSR 2.0 removal. The unused params are kept for call-site compatibility (especially cross-repo), and the return types are harmless but misleading.

Addressed in two parts:

Dead code — deleted in b5212b5:

PrivacyRequest.get_results — confirmed zero callers

extract_key_for_address — confirmed zero callers

start_function — confirmed zero callers

Unused params / misleading return types — deferring to follow-up PR:
The erasure_runner (5 unused params) and consent_runner (2 unused params) cleanup requires coordinated changes across fides (request_runner_service.py, tests/conftest.py) and fidesplus (saas_test_utils.py + ~20 SaaS test files). Same for updating return types to NoReturn. Will track as a separate cleanup ticket.

- Remove "DSR 3.0" / "DSR 2.0" from docstrings and comments in graph_runners, graph_task, test_enabled_actions, and test_execution - Remove unused `request` fixture param from manual webhook tests - Delete dead code: PrivacyRequest.get_results, extract_key_for_address, start_function (all confirmed zero callers) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

galvana · 2026-02-26T03:10:52Z

All inline comments addressed in b5212b5. Summary:

DSR 3.0/2.0 references: Removed from all flagged docstrings and comments
Dead code: Deleted get_results, extract_key_for_address, start_function (all confirmed zero callers)
Manual webhook tests: Kept — they cover live enabled_actions filtering behavior with no other integration test covering this path. Removed unused request fixture param.
Unused runner params / return types: Deferring to follow-up PR due to cross-repo blast radius (~20 fidesplus test files affected)

JadeCara

This looks so clean! 🧹

Co-authored-by: Adrian Galvan <galvana@uci.edu> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Adrian Galvan and others added 3 commits February 19, 2026 16:52

add changelog for PR #7438

d821270

Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

6ac4c71

galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Feb 20, 2026

Adrian Galvan and others added 7 commits February 19, 2026 18:58

Guard RequestTask status update for non-persistent instances

d46859d

Restore the request_task.id check in GraphTask.update_status() to skip db.merge for in-memory mock RequestTask objects used by tests. Co-authored-by: Cursor <cursoragent@cursor.com>

Fix test expecting DSR 2.0 re-raise on consent error

269d928

The retry decorator no longer re-raises exceptions for non-persistent RequestTasks. Update test to verify the error is caught and logged rather than propagated. Co-authored-by: Cursor <cursoragent@cursor.com>

Remove DSR 2.0-specific erasure order tests

d1041c6

These tests called access_runner/erasure_runner directly which now always raise PrivacyRequestExit. Their docstrings noted the DSR 3.0 equivalents exist in test_create_request_tasks.py. Co-authored-by: Cursor <cursoragent@cursor.com>

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

317fcf8

Removing unnecessary test

a02e668

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

38ffb72

galvana marked this pull request as ready for review February 21, 2026 09:10

galvana requested review from a team as code owners February 21, 2026 09:10

galvana requested review from RobertKeyser and johnewart and removed request for a team, RobertKeyser and johnewart February 21, 2026 09:10

vercel bot deployed to Preview – fides-plus-nightly February 21, 2026 09:13 View deployment

greptile-apps bot reviewed Feb 21, 2026

View reviewed changes

galvana force-pushed the ENG-2213-remove-dsr-2.0-code branch from f782d37 to 38ffb72 Compare February 22, 2026 06:57

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

8b10cf0

vercel bot deployed to Preview – fides-plus-nightly February 23, 2026 17:06 View deployment

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

19e816f

vercel bot deployed to Preview – fides-plus-nightly February 25, 2026 00:20 View deployment

galvana added 2 commits February 25, 2026 08:05

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

e4461f7

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

0b1003f

vercel bot deployed to Preview – fides-plus-nightly February 25, 2026 16:23 View deployment

JadeCara reviewed Feb 25, 2026

View reviewed changes

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

b329a9a

galvana requested a review from JadeCara February 26, 2026 03:14

vercel bot deployed to Preview – fides-plus-nightly February 26, 2026 03:18 View deployment

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

f1eeea0

vercel bot deployed to Preview – fides-plus-nightly February 26, 2026 22:48 View deployment

JadeCara approved these changes Feb 26, 2026

View reviewed changes

Merge branch 'main' into ENG-2213-remove-dsr-2.0-code

ee4839e

vercel bot deployed to Preview – fides-plus-nightly February 26, 2026 22:58 View deployment

galvana enabled auto-merge February 26, 2026 22:59

galvana added this pull request to the merge queue Feb 26, 2026

Merged via the queue into main with commit 79f519a Feb 26, 2026
53 of 54 checks passed

galvana deleted the ENG-2213-remove-dsr-2.0-code branch February 26, 2026 23:31

Linker44 pushed a commit that referenced this pull request Mar 23, 2026

ENG-2213: Remove deprecated DSR 2.0 code (#7438)

d89f3c0

Co-authored-by: Adrian Galvan <galvana@uci.edu> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Conversation

galvana commented Feb 20, 2026 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description Of Changes

Code Changes

Steps to Confirm

Pre-Merge Checklist

Uh oh!

vercel bot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps bot commented Feb 21, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

JadeCara left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

galvana commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JadeCara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

galvana commented Feb 20, 2026 •

edited by atlassian bot

Loading

vercel bot commented Feb 20, 2026 •

edited

Loading

galvana commented Feb 26, 2026 •

edited

Loading